Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Sampler.ShouldSample parent parameter to be Context #881

Merged
merged 10 commits into from
Oct 20, 2020
Merged

Update Sampler.ShouldSample parent parameter to be Context #881

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
6cf28c8
Change Sampler.ShouldSample to get full parent Context.
Oberon00 Aug 26, 2020
7fffa70
Link to Context.
Oberon00 Aug 26, 2020
c02f9ea
Merge branch 'master' into samplerparent
Oberon00 Sep 24, 2020
9b5eb84
SpanContext is never stored in Context anymore
Oberon00 Oct 6, 2020
5245d6d
Add CHANGELOG.
Oberon00 Oct 6, 2020
2ea557e
Wording.
Oberon00 Oct 6, 2020
aa67bf6
Merge branch 'master' into samplerparent
arminru Oct 6, 2020
f081f86
Add compliance matrix entry.
Oberon00 Oct 13, 2020
7494123
Merge remote-tracking branch 'upstream/master' into samplerparent
Oberon00 Oct 13, 2020
ca1a5cc
Merge branch 'master' into samplerparent
arminru Oct 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,8 @@ Updates:
([#984](https://github.com/open-telemetry/opentelemetry-specification/pull/984)
- Metrics SDK: Specify TBD default aggregation for ValueRecorder
([#984](https://github.com/open-telemetry/opentelemetry-specification/pull/984)
- Trace SDK: Sampler.ShouldSample gets parent Context instead of SpanContext
([#881](https://github.com/open-telemetry/opentelemetry-specification/pull/881))
- SDK: Specify known values, as well as basic error handling for OTEL_PROPAGATORS.
([#962](https://github.com/open-telemetry/opentelemetry-specification/pull/962))
([#995](https://github.com/open-telemetry/opentelemetry-specification/pull/995))
Expand Down
1 change: 1 addition & 0 deletions spec-compliance-matrix.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ status of the feature is not known.
|RecordException with extra parameters | - | + | + | [-](https://github.com/open-telemetry/opentelemetry-python/issues/1102) | - | - | | + | - | + |
|[Sampling](https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/trace/sdk.md#sampling)|
|Allow samplers to modify tracestate | | | | [-](https://github.com/open-telemetry/opentelemetry-python/issues/1220) | | | | | | |
|ShouldSample gets full parent Context | | | | | | | | | | |

## Baggage

Expand Down
3 changes: 2 additions & 1 deletion specification/trace/sdk.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,8 @@ Returns the sampling Decision for a `Span` to be created.

**Required arguments:**

* Parent `SpanReference`. May be invalid to indicate a root span.
* [`Context`](../context/context.md) with parent `Span`.
Oberon00 marked this conversation as resolved.
Show resolved Hide resolved
The Span's SpanContext may be invalid to indicate a root span.
* `TraceId` of the `Span` to be created.
If the parent `SpanReference` contains a valid `TraceId`, they MUST always match.
* Name of the `Span` to be created.
Expand Down