Rename Ignore to Drop for SamplingResult #956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iNikem
approved these changes
Sep 16, 2020
Oberon00
approved these changes
Sep 16, 2020
Oberon00
added
area:sampling
carlosalberto
approved these changes
Sep 16, 2020
arminru
approved these changes
Sep 16, 2020
This was referenced Sep 16, 2020
bogdandrutu
approved these changes
Sep 17, 2020
2 tasks
evantorrie
added a commit
to open-telemetry/opentelemetry-go
that referenced
this pull request
Sep 21, 2020
MrAlias
added a commit
to open-telemetry/opentelemetry-go
that referenced
this pull request
Sep 22, 2020
* Rename SamplingDecision enum values As prescribed in open-telemetry/opentelemetry-specification#938 and open-telemetry/opentelemetry-specification#956. * Include in Changelog Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
shbieng
added a commit
to shbieng/opentelemetry-go
that referenced
this pull request
Aug 26, 2022
* Rename SamplingDecision enum values As prescribed in open-telemetry/opentelemetry-specification#938 and open-telemetry/opentelemetry-specification#956. * Include in Changelog Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing the following comment as many seem to have agreed to it.
#938 (comment)
Changes
Please provide a brief description of the changes here. Update the
CHANGELOG.mdfor non-trivial changes. IfCHANGELOG.mdis updated,also be sure to update
spec-compliance-matrix.mdif necessary.Related issues #
Related oteps #