Remove obsolete http.status_text from semantic conventions
#972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oberon00
approved these changes
Sep 18, 2020
| @@ -44,7 +44,7 @@ In the case of an HTTP redirect, the request should normally be considered succe | |||
| unless the client aborts following redirects due to hitting some limit (redirect loop). | |||
| If following a (chain of) redirect(s) successfully, the status should be set according to the result of the final HTTP request. | |||
|
|
|||
| Don't set the span status description if the reason can be inferred from `http.status_code` and `http.status_text`. | |||
| Don't set the span status description if the reason can be inferred from `http.status_code`. | |||
There was a problem hiding this comment.
I think we can leave this out completely.
There was a problem hiding this comment.
I think it's fine to mention that one should not set the reason phrase as status message.
iNikem
approved these changes
Sep 18, 2020
cijothomas
approved these changes
Sep 18, 2020
|
I'm totally in favor of this change. Can we remove it from the HTTP metrics semantic convention at the same time, or should I open a separate issue for that? |
|
I think we should remove it in this PR actually. |
|
😅 Sorry I missed that. Looks good to me then. |
tigrannajaryan
approved these changes
Sep 18, 2020
|
Sufficient approvals on here and wide consensus on the issue to remove it, merging. |
This was referenced Sep 22, 2020
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #950.