Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the header name for otel baggage, and version date #981

Merged
merged 1 commit into from
Sep 22, 2020
Merged

Update the header name for otel baggage, and version date #981

merged 1 commit into from
Sep 22, 2020

Conversation

bogdandrutu
Copy link
Member

@bogdandrutu bogdandrutu commented Sep 22, 2020 •
edited
Loading

Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com

Updates #879

Changes

For the moment still use a different name to protect against may possible breaking changes to the w3c baggage header.

@bogdandrutu bogdandrutu requested review from a team as code owners September 22, 2020 00:55
@arminru
Copy link
Member

arminru commented Sep 22, 2020

@bogdandrutu Are you sure this Fixes #879? The issue is about adopting the standard header name Baggage whereas this PR is about changing the temporary header we're using within OTel to prepare for potential breaking changes in the W3C spec.
Apart from that, please add a changelog entry and a spec compliance matrix entry to keep track of implementations adopting the change.

@carlosalberto
Copy link
Contributor

cc @mwear @dyladan

arminru
arminru approved these changes Sep 22, 2020
View reviewed changes
Copy link
Member

@arminru arminru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a changelog entry and a spec compliance matrix entry to keep track of implementations adopting the change.

codeboten
codeboten approved these changes Sep 22, 2020
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bogdandrutu
Update the header name for otel baggage, and version date
3a5309a 
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@bogdandrutu
Copy link
Member Author

@arminru "compliance matrix entry" no entries for baggage. I will add them in a separate PR

@bogdandrutu bogdandrutu merged commit 26863d9 into open-telemetry:master Sep 22, 2020
@jtescher jtescher mentioned this pull request Sep 22, 2020
Closed
@fbogsany fbogsany mentioned this pull request Sep 23, 2020
Closed
@mtwo
Copy link
Member

mtwo commented Sep 24, 2020

@bogdandrutu I thought that the plan was to use 'baggage' rather than 'otelbaggage'?

@mwear
Copy link
Member

mwear commented Sep 24, 2020

I was under the same impression @mtwo.

@carlosalberto
Copy link
Contributor

@mwear @mtwo See #993 ;)

@mtwo
Copy link
Member

mtwo commented Sep 25, 2020

Bah, missed that - sorry! Thanks @carlosalberto and @bogdandrutu !

@bogdandrutu bogdandrutu deleted the otelbaggage branch September 25, 2020 21:20
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeboten codeboten codeboten approved these changes

@carlosalberto carlosalberto carlosalberto approved these changes

@MrAlias MrAlias MrAlias approved these changes

@arminru arminru arminru approved these changes

Assignees

@jmacd jmacd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@bogdandrutu @arminru @carlosalberto @mtwo @mwear @codeboten @MrAlias @jmacd