Define Propagation-only Span to simplify active Span logic in Context. #994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oberon00
reviewed
Sep 23, 2020
Oberon00
reviewed
Sep 23, 2020
Oberon00
reviewed
Sep 23, 2020
Oberon00
reviewed
Sep 23, 2020
bogdandrutu
reviewed
Sep 23, 2020
Co-authored-by: Christian Neumüller <christian+github@neumueller.me>
Co-authored-by: Christian Neumüller <christian+github@neumueller.me>
|
@Oberon00 @bogdandrutu @mwear Feedback applied. Please review ;) |
carlosalberto
changed the title
yurishkuro
approved these changes
Sep 24, 2020
jmacd
approved these changes
Sep 24, 2020
Oberon00
reviewed
Sep 24, 2020
Oberon00
reviewed
Sep 24, 2020
Oberon00
approved these changes
Sep 24, 2020
anuraaga
reviewed
Sep 24, 2020
|
Renamed to |
Oberon00
reviewed
Sep 24, 2020
|
|
||
| The API MUST provide an operation for wrapping a `SpanContext` with an object | ||
| implementing the `Span` interface. This is done in order to expose a `SpanContext` | ||
| as a `Span` in operations such as in-process `Span` propagation. | ||
|
|
||
| If a new type is required for supporting this operation, it SHOULD be named `PropagatorOnlySpan`. | ||
| If a new type is required for supporting this operation, it SHOULD be named `PropagatedSpan`. |
There was a problem hiding this comment.
Please decide between "Propagated Span" and "PropagatedSpan"
There was a problem hiding this comment.
Propagated Span is a concept, PropagatedSpan is the name (as Ruby does not need to expose it).
There was a problem hiding this comment.
I would think it's cleaner if we named the concepted PropagatedSpan too, but this is only an nipick anyway (I approved the PR)
anuraaga
approved these changes
Sep 24, 2020
bogdandrutu
approved these changes
Sep 24, 2020
This was referenced Oct 1, 2020
This was referenced Oct 9, 2020
tsloughter
added a commit
to tsloughter/opentelemetry-specification
that referenced
this pull request
Oct 21, 2020
… Context. (open-telemetry#994)" This reverts commit d14c9b7.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #949
Changes
Define the notion of a
PropagatedSpan, which wraps aSpanContext, and can be leveraged to simplify the activeSpanlogic when detecting the parentSpanin a givenContext(so we don't have to store aSpanand aSpanContextinContext).(Observe I tried to keep it as simple as possible in order to expedite this PR as much as possible ;) )