Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process for authoritative 'getting started' guides #472

Closed
Tracked by #769
austinlparker opened this issue Mar 1, 2021 · 7 comments
Closed
Tracked by #769

Process for authoritative 'getting started' guides #472

austinlparker opened this issue Mar 1, 2021 · 7 comments

Comments

@austinlparker
Copy link
Member

austinlparker commented Mar 1, 2021

Per comments in maintainers meeting, SIG maintainers desire a more clear process for handling website 'getting started' docs updates. Suggested process is this -

  • SIG maintainers create a new website_docs directory at the root of their repo.
  • The structure of this directory should mirror the subdirectory structure appropriate to that language
    • For example, Java would maintain the contents of ./content/en/docs/java in their website_docs directory, and so forth.
  • Upon a release of the associated package, a member of that SIG should open a PR with the content of their website_docs directory applied to the appropriate location in the opentelemetry.io repository.
    • Alternately, they may open an issue for a comms SIG maintainer to perform this update.

cc @open-telemetry/docs-approvers @open-telemetry/docs-maintainers for discussion before 3/8 Maintainer's Meeting.


Edits (@chalin)

Renamed website-docs to website_docs in the text above, since that is what seems to be used across the language repos.

Here is a list of the code repos with an indication of their status (as of 2021/09/25):

Repo* Has website_docs folder Has docs-update GH Action Note
opentelemetry-collector ☑️ ☑️ Docs are back in this repo - #4042
opentelemetry-cpp ✖️ ✖️ Docs in this repo. Doc update via documented process.
opentelemetry-dotnet ✖️ ✖️ Docs in this repo. Doc update via documented process.
opentelemetry-erlang ☑️ ☑️* Docs are back in this repo: #801. *open-telemetry/opentelemetry-erlang#285
opentelemetry-go ✖️ Setup as submodule in this repo by #690
opentelemetry-java ☑️* Setup as submodule in this repo by #739. *open-telemetry/opentelemetry-java#3690
opentelemetry-js ☑️ ✖️ Docs are back in this repo - #722
opentelemetry-php ☑️* *open-telemetry/opentelemetry-php#435
opentelemetry-python ☑️* *open-telemetry/opentelemetry-python#2171
opentelemetry-ruby ✖️ Setup as submodule in this repo by #765
opentelemetry-rust ☑️ ✖️ Docs are back in this repo - open-telemetry/opentelemetry-rust#645
opentelemetry-swift ☑️ ✖️ Docs are back in this repo - open-telemetry/opentelemetry-swift#243

*The repo link, is the link to the PR that created the website_docs folder.

@jkwatson
Copy link
Contributor

jkwatson commented Mar 8, 2021

What format would these docs be in?

@austinlparker
Copy link
Member Author

Markdown. The only real requirement is that they have a block at the beginning like so, with appropriate frontmatter (see https://gohugo.io/content-management/front-matter/) -

---
title: "Automatic Instrumentation"
weight: 3
---

They can also use any other features available to the docs site, such as tabs by calling the appropriate blocks (as seen in the Erlang/Elixir docs) -

{{< tabs Erlang Elixir >}}

{{< tab >}}
$ rebar3 new release otel_getting_started
{{< /tab >}}

{{< tab >}}
$ mix new otel_getting_started
{{< /tab >}}

{{< /tabs >}}

@tedsuo
Copy link
Contributor

tedsuo commented Mar 15, 2021

How should links be handled?

@austinlparker
Copy link
Member Author

Absolute links should be fine irregardless. Relative links should also be fine, as Hugo defaults to not canonifying relative links, and it tends to be kinda smart about it.. for example, in /content/en/docs/java/getting_started.md there's a link to [/docs/java/#releases-1]. Hugo will do the right thing for [../#releases-1] as well (the link it creates in both cases will be to <protocol>://<host>:<port>/docs/java/#releases-1)

The only thing I can see tripping people up is creating relative links to content outside of the website_docs directory.

@austinlparker
Copy link
Member Author

I'm going through and making PR's mirroring the website docs to SIG repos today.

nachoBonafonte pushed a commit to open-telemetry/opentelemetry-swift that referenced this issue Mar 30, 2021
Add opentelemetry.io docs
Per open-telemetry/opentelemetry.io#472, we're mirroring the docs content on the website to each SIG. When a release occurs and these docs are updated, please make an issue or PR mirroring them to their appropriate location in the website repo (https://github.com/open-telemetry/opentelemetry.io/tree/main/content/en/docs/swift).
tigrannajaryan pushed a commit to open-telemetry/opentelemetry-collector that referenced this issue May 19, 2021
Per open-telemetry/opentelemetry.io#472, we're mirroring the docs content on the website to each SIG. When a release occurs and these docs are updated, please make an issue or PR mirroring them to their appropriate location in the website repo (https://github.com/open-telemetry/opentelemetry.io/tree/main/content/en/docs/collector).
dashpole pushed a commit to dashpole/opentelemetry-collector that referenced this issue Jun 14, 2021
Per open-telemetry/opentelemetry.io#472, we're mirroring the docs content on the website to each SIG. When a release occurs and these docs are updated, please make an issue or PR mirroring them to their appropriate location in the website repo (https://github.com/open-telemetry/opentelemetry.io/tree/main/content/en/docs/collector).
@chalin chalin added the p1-high label Aug 12, 2021
@chalin
Copy link
Contributor

chalin commented Sep 24, 2021

Superseded by #730, but I'll keep this open for now since I'm still updating the table with statuses.

@chalin chalin removed the p1-high label Sep 24, 2021
@chalin
Copy link
Contributor

chalin commented Sep 25, 2021

Status table is complete. Closing in favor #730.

@chalin chalin closed this as completed Sep 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants