Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add demo doc pages, drop tmp git submodule #2270

Merged

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Feb 3, 2023

  • Contributes to Migrate demo docs to this repo #2269
  • Adds the demo doc pages "as is" (as they were created from the adjust script). I'll do clean up in subsequent PRs
  • Drops the demo git submodule
  • Reverts changes to the submodule-docs adjust and copy scripts

Preview: https://deploy-preview-2270--opentelemetry.netlify.app/docs/demo/

Note: I'll update the CODEOWNERS file in a followup PR.

/cc @open-telemetry/demo-approvers


Note: Other than page meta data (date modified, etc), and GH commit references, there are no changes to the generated site files. And only the demo doc pages (and the sitemap) are affected by this PR:

$ (cd public && git diff -bw --ignore-blank-lines) | grep ^diff | wc -l
      38
$ (cd public && git diff -bw --ignore-blank-lines) | grep ^diff | head 
diff --git a/docs/demo/current_architecture/index.html b/docs/demo/current_architecture/index.html
diff --git a/docs/demo/demo_features/index.html b/docs/demo/demo_features/index.html
diff --git a/docs/demo/demo_screenshots/index.html b/docs/demo/demo_screenshots/index.html
...
$ (cd public && git diff -bw --ignore-blank-lines) | grep ^diff | grep -v /docs/demo/
diff --git a/sitemap.xml b/sitemap.xml
$ (cd public && git diff -bw --ignore-blank-lines -I 'dateModified|lastmod|modified_time|text-muted|Last modified|/div|og:site_name|^\s+$') | head
$

@chalin chalin requested a review from a team February 3, 2023 22:07
@chalin chalin mentioned this pull request Feb 3, 2023
8 tasks
Copy link
Member

@mviitane mviitane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm missing the original folder structure in the navigation. Now, only one of the folders are visible in the preview. However, it's fine if the improved navigation is added in the following PRs.

@julianocosta89
Copy link
Member

The file content/en/docs/demo/img/opentelemetry-logo-nav.png is not being used anymore.
We should be good to remove it.

@chalin
Copy link
Contributor Author

chalin commented Feb 6, 2023

@mviitane @julianocosta89: yes, I'll address those issues in followup PRs. Can one of you (or another demo-approver) approve this PR?

@chalin chalin merged commit 7543257 into open-telemetry:main Feb 6, 2023
@chalin chalin deleted the chalin-im-embed-demo-doc-pages-2023-02-03 branch February 6, 2023 15:53
@chalin
Copy link
Contributor Author

chalin commented Feb 6, 2023

I'm missing the original folder structure in the navigation. Now, only one of the folders are visible in the preview. However, it's fine if the improved navigation is added in the following PRs.

Here's the followup issue:

@chalin
Copy link
Contributor Author

chalin commented Feb 6, 2023

And here's the followup PR:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants