Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docsy at v0.6.0 + Mermaid workaround #2424

Merged
merged 2 commits into from
Mar 1, 2023
Merged

Docsy at v0.6.0 + Mermaid workaround #2424

merged 2 commits into from
Mar 1, 2023

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Feb 28, 2023 •
edited

@chalin chalin requested a review from a team as a code owner February 28, 2023 15:55
@chalin chalin marked this pull request as draft February 28, 2023 15:55
@chalin chalin marked this pull request as ready for review February 28, 2023 16:02
@chalin chalin mentioned this pull request Feb 28, 2023
Closed
7 tasks
deining
deining suggested changes Feb 28, 2023
View reviewed changes
Copy link
Contributor

@deining deining left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would go for the latest mermaid version (either v9 or v10).

static/refcache.json Show resolved Hide resolved
@chalin chalin added CI/infra CI & infrastructure docsy labels Feb 28, 2023
svrnm
svrnm approved these changes Mar 1, 2023
View reviewed changes
Copy link
Member

@svrnm svrnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did some clicking in the preview yesterday and didn't run into any major issues. @chalin update whenever you feel ready.

@chalin chalin force-pushed the chalin-im-docsy-upgrade-2023-02-28b branch from bfe6dbd to 15c56a8 Compare March 1, 2023 12:13
@chalin
Copy link
Contributor Author

chalin commented Mar 1, 2023

Thanks @svrnm!

@chalin chalin merged commit f99b39a into open-telemetry:main Mar 1, 2023
@chalin chalin deleted the chalin-im-docsy-upgrade-2023-02-28b branch March 1, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deining deining deining requested changes

@svrnm svrnm svrnm approved these changes

Assignees
No one assigned
Labels
CI/infra CI & infrastructure docsy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chalin @svrnm @deining