SCSS variable cleanup in prep for Docsy upgrade #2440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalin
commented
Mar 2, 2023
| @@ -1,138 +1,24 @@ | |||
| .registry { | |||
There was a problem hiding this comment.
The use of these styles are nowhere to be found, including in the commit that introduced them:
chalin
commented
Mar 2, 2023
| background-color: $utilities; | ||
| } | ||
|
|
||
| .badge-tracer { |
There was a problem hiding this comment.
There is no tracer component, so this style was never used.
chalin
commented
Mar 2, 2023
| background-color: $dark-blue; | ||
| } | ||
|
|
||
| .badge-instrumentation { |
There was a problem hiding this comment.
This is missing the .badge context, and so was never used.
chalin
commented
Mar 2, 2023
Comment on lines
-3
to
-4
| $twitter-blue: #00aced; | ||
| $gitter-magenta: #ec1363; |
There was a problem hiding this comment.
These two component variables are not used.
chalin
commented
Mar 2, 2023
Comment on lines
-15
to
-16
| $google_font_name: 'Noto Sans'; | ||
| $google_font_family: 'Noto+Sans:300,400,600,700'; |
There was a problem hiding this comment.
Redefining $google_font_* has no effect when $td-enable-google-fonts is false
chalin
commented
Mar 2, 2023
Comment on lines
-18
to
-20
| $enable-gradients: false; | ||
| $enable-rounded: true; | ||
| $enable-shadows: false; |
There was a problem hiding this comment.
Dropping these, falling back on Docsy defaults.
7 tasks
svrnm
approved these changes
Mar 2, 2023
chalin
force-pushed
the
chalin-im-scss-fixes-2023-03-02
branch
from
5d0acd2
to
e566cc1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview:
In particular, you'll note that badge colors have not changed: