-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove foldable nav #3243
Remove foldable nav #3243
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this project pulls the Docsy theme as a submodule. If that's the case, how do we go about branching out from upstream?
@@ -103,10 +103,6 @@ | |||
} | |||
} | |||
|
|||
.foldable-nav { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you should also remove the class from whatever HTML element has it attached?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure.
I checked the repo.
It seems there is not any HTML element in this repo.
@chalin has all the answers for that :-) Please be patient with an answer here, I don't think this issue here is super urgent right now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The necessary Docsy fix mentioned in the original issue hasn't officially landed in a Docsy release yet, so this PR won't work.
A new Docsy release is planned for "real soon now" :).
Thanks for the effort @pegasas, but I'm going to close this since there are more changes for me to do as I address #3157.
try to resolve #3157