Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove foldable nav #3243

Closed
wants to merge 1 commit into from
Closed

Remove foldable nav #3243

wants to merge 1 commit into from

Conversation

pegasas
Copy link
Contributor

@pegasas pegasas commented Sep 9, 2023

try to resolve #3157

@pegasas pegasas requested a review from a team as a code owner September 9, 2023 11:26
@svrnm
Copy link
Member

svrnm commented Sep 11, 2023

thanks for raising this @pegasas

@chalin can you take a look, thanks.

@svrnm svrnm requested a review from chalin September 11, 2023 07:28
Copy link
Member

@theletterf theletterf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this project pulls the Docsy theme as a submodule. If that's the case, how do we go about branching out from upstream?

@@ -103,10 +103,6 @@
}
}

.foldable-nav {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should also remove the class from whatever HTML element has it attached?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure.
I checked the repo.
It seems there is not any HTML element in this repo.

@svrnm svrnm added the CI/infra CI & infrastructure label Sep 19, 2023
@svrnm
Copy link
Member

svrnm commented Sep 19, 2023

Not sure if this project pulls the Docsy theme as a submodule. If that's the case, how do we go about branching out from upstream?

@chalin has all the answers for that :-) Please be patient with an answer here, I don't think this issue here is super urgent right now.

Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The necessary Docsy fix mentioned in the original issue hasn't officially landed in a Docsy release yet, so this PR won't work.

A new Docsy release is planned for "real soon now" :).

Thanks for the effort @pegasas, but I'm going to close this since there are more changes for me to do as I address #3157.

@chalin chalin closed this Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/infra CI & infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix sidenav height and padding by updating Docsy
4 participants