Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Refactor OTel-Java related front-matter version keys + autoupdate script changes #3503

Merged

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Nov 6, 2023

  • Contributes to:
  • Refactors the OTel-Java related front-matter version keys so that they are all in docs/instrumentation/java/_index.md. This enables all pages in that section to access the variables
  • Renames the variables so that they are shorter, given the context. I.e., for pages under the Java section, vers.semconv means the version of Java semconv, etc.
  • There are no changes to the generated site files (modulo timestamps etc):
    $ (cd public && git diff) | grep ^diff 
    diff --git a/docs/instrumentation/java/automatic/annotations/index.html b/docs/instrumentation/java/automatic/annotations/index.html
    diff --git a/docs/instrumentation/java/exporters/index.html b/docs/instrumentation/java/exporters/index.html
    diff --git a/docs/instrumentation/java/index.html b/docs/instrumentation/java/index.html
    diff --git a/docs/instrumentation/java/manual/index.html b/docs/instrumentation/java/manual/index.html
    diff --git a/docs/instrumentation/java/resources/index.html b/docs/instrumentation/java/resources/index.html
    diff --git a/site/index.html b/site/index.html
    diff --git a/sitemap.xml b/sitemap.xml
    $ (cd public && git diff -I 'dateModified|lastmod|modified_time|Last modified') | grep ^diff               
    diff --git a/site/index.html b/site/index.html

@chalin chalin force-pushed the chalin-im-java-vers-fix-2023-11-06 branch from 38e57ff to 49e3d24 Compare November 6, 2023 15:53
@chalin chalin changed the title [CI] Refactor OTel-Java related front-matter version keys Refactor OTel-Java related front-matter version keys Nov 6, 2023
@chalin chalin changed the title Refactor OTel-Java related front-matter version keys [CI] Refactor OTel-Java related front-matter version keys + autoupdate script changes Nov 6, 2023
@cartermp cartermp merged commit c1ca5eb into open-telemetry:main Nov 6, 2023
14 checks passed
@chalin chalin deleted the chalin-im-java-vers-fix-2023-11-06 branch November 6, 2023 17:37
@chalin
Copy link
Contributor Author

chalin commented Nov 6, 2023

For the record, I just tested the updated action, and it runs fine (when there are no updates); see, https://github.com/open-telemetry/opentelemetry.io/actions/runs/6774462331/job/18411562909.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants