Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create blog post about Prometheus and OpenTelemetry #4119

Merged
merged 66 commits into from
Sep 4, 2024
Merged

Conversation

reese-lee
Copy link
Member

@reese-lee reese-lee commented Mar 10, 2024

This is a blog post written by myself and @avillela. It is based on a talk we are delivering at KubeCon EU 2024. It is about how OpenTelemetry and Prometheus can work together, and talks about some of the different components available in OTel for your Prometheus metrics.


Preview: https://deploy-preview-4119--opentelemetry.netlify.app/blog/2024/prom-and-otel/

@reese-lee reese-lee requested a review from a team March 10, 2024 21:18
Copy link
Member

@theletterf theletterf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some nits in a first pass. I really like the topic and the content! My only concern is that, from the title, I expected a more conceptual post, but then the post delves into a rather detailed tutorial. Could there be a way of better setting expectations from the title and intro?

content/en/blog/2024/prom-and-otel/index.md Outdated Show resolved Hide resolved
content/en/blog/2024/prom-and-otel/index.md Outdated Show resolved Hide resolved
content/en/blog/2024/prom-and-otel/index.md Outdated Show resolved Hide resolved
content/en/blog/2024/prom-and-otel/index.md Outdated Show resolved Hide resolved
content/en/blog/2024/prom-and-otel/index.md Outdated Show resolved Hide resolved
content/en/blog/2024/prom-and-otel/index.md Outdated Show resolved Hide resolved
content/en/blog/2024/prom-and-otel/index.md Outdated Show resolved Hide resolved
content/en/blog/2024/prom-and-otel/index.md Outdated Show resolved Hide resolved
content/en/blog/2024/prom-and-otel/index.md Outdated Show resolved Hide resolved
content/en/blog/2024/prom-and-otel/index.md Outdated Show resolved Hide resolved
Copy link
Contributor

@aknuds1 aknuds1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a lot of text :) Please see comments.

content/en/blog/2024/prom-and-otel/index.md Outdated Show resolved Hide resolved
content/en/blog/2024/prom-and-otel/index.md Outdated Show resolved Hide resolved
content/en/blog/2024/prom-and-otel/index.md Outdated Show resolved Hide resolved
content/en/blog/2024/prom-and-otel/index.md Outdated Show resolved Hide resolved
content/en/blog/2024/prom-and-otel/index.md Outdated Show resolved Hide resolved
content/en/blog/2024/prom-and-otel/index.md Outdated Show resolved Hide resolved
content/en/blog/2024/prom-and-otel/index.md Outdated Show resolved Hide resolved
content/en/blog/2024/prom-and-otel/index.md Outdated Show resolved Hide resolved
content/en/blog/2024/prom-and-otel/index.md Outdated Show resolved Hide resolved
content/en/blog/2024/prom-and-otel/index.md Outdated Show resolved Hide resolved
content/en/blog/2024/prom-and-otel/index.md Outdated Show resolved Hide resolved
content/en/blog/2024/prom-and-otel/index.md Outdated Show resolved Hide resolved
content/en/blog/2024/prom-and-otel/index.md Outdated Show resolved Hide resolved
content/en/blog/2024/prom-and-otel/index.md Outdated Show resolved Hide resolved
@reese-lee
Copy link
Member Author

Also requesting a review from @open-telemetry/operator-ta-maintainers

reese-lee added a commit that referenced this pull request Mar 13, 2024
Incorporated suggestion from [this review](#4119 (review)).
@reese-lee
Copy link
Member Author

@theletterf I incorporated your comment about setting clearer expectations in the intro. Is this more effective?

While both Prometheus and OTel emit metrics, there is a lot to cover on the
differences and similarities, and is out of scope for this article. Rather, we
want to show you how OTel supports Prometheus, specifically in a Kubernetes
environment. You'll learn:

  • How the OTel Collector's Prometheus Receiver can be used to ingest Prometheus
    metrics.
  • Alternative methods for Prometheus metric collection through OTel-native
    options such as the K8s cluster receiver and Kubelet stats receiver.

We will also do a technical dive into the OTel Operator's Target Allocator (TA)
and learn:

  • How it can be used for Prometheus service discovery.
  • How it ensures even distribution of Prometheus targets.

reese-lee added a commit that referenced this pull request Mar 13, 2024
Specifically address this [review comment](#4119 (comment)).
reese-lee added a commit that referenced this pull request Mar 13, 2024
This specifically addresses [this review comment](#4119 (comment)).
Copy link
Member

@theletterf theletterf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! Thanks!

content/en/blog/2024/prom-and-otel/index.md Outdated Show resolved Hide resolved
content/en/blog/2024/prom-and-otel/index.md Outdated Show resolved Hide resolved
content/en/blog/2024/prom-and-otel/index.md Outdated Show resolved Hide resolved
Copy link
Member

@gouthamve gouthamve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for writing this! Looking forward to your Kubecon talk!

I left a few notes that I think better represent the Prometheus capabilities.

content/en/blog/2024/prom-and-otel/index.md Outdated Show resolved Hide resolved
content/en/blog/2024/prom-and-otel/index.md Outdated Show resolved Hide resolved
reese-lee added a commit that referenced this pull request Mar 13, 2024
Addresses [this review comment](#4119 (comment)) and [this one](#4119 (comment)).
Copy link
Contributor

@jaronoff97 jaronoff97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hype!! Thanks for writing this up!

content/en/blog/2024/prom-and-otel/index.md Outdated Show resolved Hide resolved
content/en/blog/2024/prom-and-otel/index.md Outdated Show resolved Hide resolved
content/en/blog/2024/prom-and-otel/index.md Outdated Show resolved Hide resolved
content/en/blog/2024/prom-and-otel/index.md Outdated Show resolved Hide resolved
content/en/blog/2024/prom-and-otel/index.md Outdated Show resolved Hide resolved
content/en/blog/2024/prom-and-otel/index.md Show resolved Hide resolved
content/en/blog/2024/prom-and-otel/index.md Outdated Show resolved Hide resolved
reese-lee added a commit that referenced this pull request Mar 13, 2024
reese-lee added a commit that referenced this pull request Mar 14, 2024
Addresses [this review comment](#4119 (comment)).
@gouthamve
Copy link
Member

Also, this just got published: https://prometheus.io/blog/2024/03/14/commitment-to-opentelemetry/

Maybe at the end we can add reference saying something along the line of "Prometheus is also making it easier to integrate natively with OpenTelemetry and here are their plans."?

@reese-lee
Copy link
Member Author

@gouthamve Gotchu! I added this:

Prometheus maintainers have also been further developing the interoperability
between the two projects from the Prometheus side to make it easier for it to be
the backend for OTLP metrics. For instance, Prometheus can now accept OTLP, and
soon, you’ll be able to use Prometheus exporters to export OTLP. So if you have a
service instrumented with a Prometheus SDK, you’ll be able to push OTLP and
take advantage of the rich Prometheus exporter ecosystem for OTel users. The
maintainers are also working on adding support for delta temporality. This
component will aggregate delta samples to their
respective cumulative counterparts. Read more about Prometheus' support for OTel
here!

content/en/blog/2024/prom-and-otel/index.md Outdated Show resolved Hide resolved
content/en/blog/2024/prom-and-otel/index.md Outdated Show resolved Hide resolved
Copy link
Contributor

@avillela avillela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@reese-lee added the mermaid diagrams. The closing back-ticks for the mermaid diagrams weren't rendering properly. You may have to manually add them.

Copy link
Contributor

@avillela avillela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add link to OTel Operator

@svrnm
Copy link
Member

svrnm commented Jun 24, 2024

@chalin we can point to this PR for the "rebase vs not-rebase" discussion, I am convinced now ;-)

@svrnm
Copy link
Member

svrnm commented Jun 24, 2024

@open-telemetry/wg-prometheus PTAL

Copy link
Contributor

@jaronoff97 jaronoff97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few minor things :) otherwise this looks great!

content/en/blog/2024/prom-and-otel/index.md Outdated Show resolved Hide resolved
content/en/blog/2024/prom-and-otel/index.md Outdated Show resolved Hide resolved
content/en/blog/2024/prom-and-otel/index.md Outdated Show resolved Hide resolved
Copy link
Contributor

@dashpole dashpole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great post!

content/en/blog/2024/prom-and-otel/index.md Outdated Show resolved Hide resolved
content/en/blog/2024/prom-and-otel/index.md Show resolved Hide resolved
content/en/blog/2024/prom-and-otel/index.md Outdated Show resolved Hide resolved
content/en/blog/2024/prom-and-otel/index.md Outdated Show resolved Hide resolved
content/en/blog/2024/prom-and-otel/index.md Outdated Show resolved Hide resolved
content/en/blog/2024/prom-and-otel/index.md Show resolved Hide resolved
content/en/blog/2024/prom-and-otel/index.md Outdated Show resolved Hide resolved
Co-authored-by: Jacob Aronoff <jaronoff97@users.noreply.github.com>
@svrnm
Copy link
Member

svrnm commented Aug 1, 2024

@reese-lee please take a look at the outstanding review comments

@svrnm
Copy link
Member

svrnm commented Aug 9, 2024

@reese-lee @avillela any updates?

@reese-lee
Copy link
Member Author

@svrnm Thank you for your patience! I believe we are good to go on this (finally). I'm not sure what to do about this failing check: "Component owners / Assign component owners (pull_request_target)"?

@opentelemetrybot opentelemetrybot requested a review from a team September 4, 2024 07:32
@svrnm
Copy link
Member

svrnm commented Sep 4, 2024

@svrnm Thank you for your patience! I believe we are good to go on this (finally). I'm not sure what to do about this failing check: "Component owners / Assign component owners (pull_request_target)"?

let me fix the failing CI checks and then I can merge it:-)

Signed-off-by: svrnm <neumanns@cisco.com>
Signed-off-by: svrnm <neumanns@cisco.com>
@opentelemetrybot opentelemetrybot requested a review from a team September 4, 2024 08:19
@svrnm svrnm added this pull request to the merge queue Sep 4, 2024
Merged via the queue into main with commit aba5a76 Sep 4, 2024
19 checks passed
@svrnm svrnm deleted the reese-lee-patch-2 branch September 4, 2024 09:22
michael2893 pushed a commit to michael2893/opentelemetry.io that referenced this pull request Sep 8, 2024
)

Signed-off-by: svrnm <neumanns@cisco.com>
Co-authored-by: Fabrizio Ferri-Benedetti <fferribenedetti@splunk.com>
Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com>
Co-authored-by: Cijo Thomas <cijo.thomas@gmail.com>
Co-authored-by: Goutham Veeramachaneni <gouthamve+github@gmail.com>
Co-authored-by: Jacob Aronoff <jaronoff97@users.noreply.github.com>
Co-authored-by: Adriana Villela <50256412+avillela@users.noreply.github.com>
Co-authored-by: Severin Neumann <neumanns@cisco.com>
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.