Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[i18n] Docs section ordering fix #4573

Merged

Conversation

chalin
Copy link
Contributor

@chalin chalin commented May 31, 2024

  • Contributes to Improved i18n support #4467
  • Fixes the order of zh top-level sections
  • Redistributes the weights of the top-level docs sections, without changing the order of en pages.
    Here's proof that the order of pages under en hasn't changed:
    $ (cd public && git diff -bw --ignore-blank-lines) | grep ^diff | grep -v zh
    diff --git a/_redirects b/_redirects
    diff --git a/en/sitemap.xml b/en/sitemap.xml
    diff --git a/site/index.html b/site/index.html

Preview:

Screenshots

Before After
image image

@chalin chalin added cleanup/refactoring i18n internationalization labels May 31, 2024
@chalin chalin requested review from a team as code owners May 31, 2024 09:04
@chalin chalin requested review from atoulme and removed request for a team May 31, 2024 09:04
@chalin chalin requested a review from a team as a code owner May 31, 2024 09:11
Copy link
Member

@windsonsea windsonsea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@chalin chalin force-pushed the chalin-im-docs-section-weights-2024-05-31 branch from df13851 to bf2ab67 Compare May 31, 2024 10:32
@chalin chalin force-pushed the chalin-im-docs-section-weights-2024-05-31 branch from bf2ab67 to 8bb29d9 Compare May 31, 2024 17:41
@chalin chalin removed the request for review from atoulme May 31, 2024 17:49
@svrnm svrnm merged commit d638c38 into open-telemetry:main Jun 3, 2024
15 checks passed
@chalin chalin deleted the chalin-im-docs-section-weights-2024-05-31 branch June 3, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[i18n] Docs section weights need to be adjusted to work with all languages
5 participants