Update libraries.md for style issues #5165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/fix:format |
|
You triggered fix:format action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/10760729048 |
|
IMPORTANT: (RE-)RUN
|
theletterf
commented
Sep 8, 2024
|
|
||
| WARNING: Generic solution to avoid duplication is under construction 🚧. |
There was a problem hiding this comment.
@open-telemetry/docs-approvers Do we still need this? Not a big fan of "under construction" messages in docs. It's sort of implicit and can be verified by anyone interested.
There was a problem hiding this comment.
I'm find with removing the more warning-y text.
theletterf
commented
Sep 8, 2024
| span you create. Refer to | ||
| [messaging conventions](/docs/specs/semconv/messaging/messaging-spans/) for | ||
| details (WARNING: messaging conventions are |
There was a problem hiding this comment.
@open-telemetry/docs-approvers Ditto on the need for this kind of messages.
cartermp
approved these changes
Sep 8, 2024
|
|
||
| WARNING: Generic solution to avoid duplication is under construction 🚧. |
There was a problem hiding this comment.
I'm find with removing the more warning-y text.
EzzioMoreira
added a commit
to EzzioMoreira/opentelemetry.io
that referenced
this pull request
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the libraries page for style guide and language issues. Adding some comments where clarification might be required. This one really needed a cleanup.