Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update example links to opentelemetry-go-contrib repository #5364

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

robinlieb
Copy link
Contributor

Go examples has been moved to opentelemetry-go-contrib repository in open-telemetry/opentelemetry-go#5801.

This PR updates docs to point to the new location of the go examples.

@robinlieb robinlieb requested a review from a team as a code owner October 9, 2024 16:03
@opentelemetrybot opentelemetrybot requested review from a team October 9, 2024 16:03
@svrnm
Copy link
Member

svrnm commented Oct 10, 2024

@open-telemetry/go-approvers does this change also impact the "roll the dice demo" that we source from the go repo right now? If so we need to change that submodule to -contrib- as well.

@dmathieu
Copy link
Member

Yes, the dice demo is indeed moved to the contrib repository.
https://github.com/open-telemetry/opentelemetry-go-contrib/tree/main/examples/dice

@svrnm
Copy link
Member

svrnm commented Oct 10, 2024

Yes, the dice demo is indeed moved to the contrib repository. open-telemetry/opentelemetry-go-contrib@main/examples/dice

thanks, let's fix that in a separate PR!

@svrnm svrnm added this pull request to the merge queue Oct 10, 2024
Merged via the queue into open-telemetry:main with commit 5e2a0b4 Oct 10, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants