Publish OpenTelemetry Schema File 1.4.0 #599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@austinlparker is this sufficient to have the schema file published at https://opentelemetry.io/schemas/1.4.0 ? |
As described in open-telemetry#577 this adds the first schema file. This should publish the file at https://opentelemetry.io/schemas/1.4.0 Merge this PR after specification 1.4.0 is released. We will automate the addition of future schemas later.
tigrannajaryan
force-pushed
the
feature/tigran/addschema
branch
from
cfe5de6
to
d490cb3
Compare
Yes, it looks sufficient, I can see it in the preview https://deploy-preview-599--opentelemetry.netlify.app/schemas/1.4.0 |
|
1.4.0 was published, we are ready to roll ;) |
tigrannajaryan
changed the title
tigrannajaryan
requested review from
austinlparker,
flands,
jparsana and
mtwo
as code owners
|
This is now ready for review and merging. It should publish our first Telemetry Schema at https://opentelemetry.io/schemas/1.4.0 |
|
@open-telemetry/docs-approvers PTAL. |
|
Will review in a few hours if someone else doesn’t catch it
…On Mon, Jun 7, 2021 at 6:24 PM Tigran Najaryan ***@***.***> wrote:
@open-telemetry/docs-approvers
<https://github.com/orgs/open-telemetry/teams/docs-approvers> PTAL.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#599 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA7S5RCJCNWLW3BDYEFT3LDTRVBJZANCNFSM457TPQFQ>
.
|
tigrannajaryan
commented
Jun 8, 2021
austinlparker
approved these changes
Jun 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #577
this adds the first schema file. This should publish the file at
https://opentelemetry.io/schemas/1.4.0
Merge this PR after specification 1.4.0 is released.
We will automate the addition of future schemas later.