Skip to content
This repository has been archived by the owner on Dec 6, 2024. It is now read-only.

Commit

Permalink
Allow omitting LogRecord in favor of build pattern in Logging SDKs (#183
Browse files Browse the repository at this point in the history
)

The discussion while implementing the Java SDK revealed that the LogRecord
data type may not be necessary. See here open-telemetry/opentelemetry-java#3759 (comment)

However, in some other languages LogRecord fits nicely (see the comment about
Python implementation in the same comment thread).

This changes allows implementators of the OTEP to choose the most idiomatic
approach for their language.
  • Loading branch information
tigrannajaryan authored Nov 15, 2021
1 parent 723f9a0 commit 1b22ca8
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions text/logs/0150-logging-library-sdk.md
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,12 @@ Methods:
trace context related fields (TraceId,SpanId,TraceFlags) if applicable before
making the call. Open Question: do we need to also pass the Baggage so that
log processors and exporters can use it if they see the need?

Note: some languages may opt to avoid having a LogRecord data type and instead
use a more idiomatic builder pattern to prepare and emit a log record (see
e.g.
[Java discussion](https://github.com/open-telemetry/opentelemetry-java/pull/3759#discussion_r738019425))

- Flush.

### LogRecord
Expand Down

0 comments on commit 1b22ca8

Please sign in to comment.