Skip to content
This repository has been archived by the owner on Dec 6, 2024. It is now read-only.

Proposal: OTLP Exporters Support for Configurable Export Behavior #131

Merged
merged 6 commits into from
Aug 13, 2020

Conversation

huyan0
Copy link
Member

@huyan0 huyan0 commented Aug 11, 2020

This OTEP stems from discussions around spec #731 and partially resolves #725. The topic has been discussed at length in the Metrics SIG meeting, and the conclusion from those discussions is reflected here.

cc @huyan0 @alolita @jmacd @bogdandrutu

huyan0 added 3 commits August 5, 2020 12:07
Based on discussions from the Metrics SIG meeting, configurable export behavior from the OTLP exporter is desired to support different mertic backends
Based on discussions from the Metrics SIG meeting, configurable export behavior from the OTLP exporter is desired to support different mertic backends
@bogdandrutu
Copy link
Member

@MrAlias
Copy link
Contributor

MrAlias commented Aug 11, 2020

@huyan0 please fix markdown lint errors :) https://app.circleci.com/pipelines/github/open-telemetry/oteps/732/workflows/d88799f9-34eb-4763-ad4e-604ed3dd5197/jobs/927

And please remove the binary DS_Store files from the git history.

@jkwatson
Copy link
Contributor

Is this a subset of the features described in OTEP 126? https://github.com/open-telemetry/oteps/blob/master/text/metrics/0126-Configurable-Metric-Aggregations.md

Or is this a requirement that OTLP exporters use the features in OTEP 126 and provide access via configuration?

@bogdandrutu
Copy link
Member

I think it is a mix of both. But most importantly it says that defaults should be cumulative

@jmacd
Copy link
Contributor

jmacd commented Aug 11, 2020

@jkwatson I support the idea that the Views configuration should be able to set the export strategy for OTLP. I see the goal of this OTEP as simply stating that (1) it should be a configuration option, (2) it defaults to cumulative. I'd say that an API to configure this is the MVP, and that a more wholistic Views API should include this feature as a configuration.

Copy link
Contributor

@MrAlias MrAlias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still need the .DS_Store binary files stripped out, but content looks good. 👍

@huyan0
Copy link
Member Author

huyan0 commented Aug 11, 2020

I have removed the extra binary files, thanks : -)

@bogdandrutu bogdandrutu merged commit d058eed into open-telemetry:master Aug 13, 2020
carlosalberto pushed a commit to carlosalberto/oteps that referenced this pull request Oct 23, 2024
…en-telemetry#131)

* add otlp export otep

* Make SDK OTLP exporters support configurable export behavior

Based on discussions from the Metrics SIG meeting, configurable export behavior from the OTLP exporter is desired to support different mertic backends

* Make SDK OTLP exporters support configurable export behavior

Based on discussions from the Metrics SIG meeting, configurable export behavior from the OTLP exporter is desired to support different mertic backends

* fix format to pass markdownlint

* add sentence to highlight cumulative -> delta is also needed

Co-authored-by: Bogdan Drutu <bogdandrutu@gmail.com>
carlosalberto pushed a commit to carlosalberto/oteps that referenced this pull request Oct 23, 2024
…en-telemetry#131)

* add otlp export otep

* Make SDK OTLP exporters support configurable export behavior

Based on discussions from the Metrics SIG meeting, configurable export behavior from the OTLP exporter is desired to support different mertic backends

* Make SDK OTLP exporters support configurable export behavior

Based on discussions from the Metrics SIG meeting, configurable export behavior from the OTLP exporter is desired to support different mertic backends

* fix format to pass markdownlint

* add sentence to highlight cumulative -> delta is also needed

Co-authored-by: Bogdan Drutu <bogdandrutu@gmail.com>
carlosalberto pushed a commit to carlosalberto/oteps that referenced this pull request Oct 30, 2024
…en-telemetry#131)

* add otlp export otep

* Make SDK OTLP exporters support configurable export behavior

Based on discussions from the Metrics SIG meeting, configurable export behavior from the OTLP exporter is desired to support different mertic backends

* Make SDK OTLP exporters support configurable export behavior

Based on discussions from the Metrics SIG meeting, configurable export behavior from the OTLP exporter is desired to support different mertic backends

* fix format to pass markdownlint

* add sentence to highlight cumulative -> delta is also needed

Co-authored-by: Bogdan Drutu <bogdandrutu@gmail.com>
carlosalberto pushed a commit to open-telemetry/opentelemetry-specification that referenced this pull request Nov 8, 2024
…en-telemetry/oteps#131)

* add otlp export otep

* Make SDK OTLP exporters support configurable export behavior

Based on discussions from the Metrics SIG meeting, configurable export behavior from the OTLP exporter is desired to support different mertic backends

* Make SDK OTLP exporters support configurable export behavior

Based on discussions from the Metrics SIG meeting, configurable export behavior from the OTLP exporter is desired to support different mertic backends

* fix format to pass markdownlint

* add sentence to highlight cumulative -> delta is also needed

Co-authored-by: Bogdan Drutu <bogdandrutu@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Delta" sums for UpDownCounter are error prone
5 participants