-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Propose "Named Tracers" #16
Propose "Named Tracers" #16
Conversation
Initial Draft: "Named Tracers"
Synchronize repository
Co-Authored-By: Armin Ruech <armin.ruech@gmail.com>
Co-Authored-By: Armin Ruech <armin.ruech@gmail.com>
Add examples section.
@bogdandrutu I'm not quite sure how we left off after yesterday's discussion in the spec meeting. Are you OK with the approach that we propose a dedicated RFC for metrics (and also logs at some later point in time) to have a better separation of concerns? |
@z1c0 I would prefer to not postpone the metrics:
I suggest that we just re-write a bit the first few paragraphs to generalize the motivation for metrics as well. Everything else stays the same: // Create a tracer/meter for given instrumentation library in a specific version.
Tracer tracer = OpenTelemetry.getTracerFactory().getTracer("io.opentelemetry.contrib.mongodb", "semver:1.0.0");
Meter meter = OpenTelemetry.getMeterFactory().getMeter("io.opentelemetry.contrib.mongodb", "semver:1.0.0"); Also do we need a way to access unnamed Tracer/Meter? |
@bogdandrutu metrics are now included in this proposal. |
Co-Authored-By: Christian Neumüller <christian+github@neumueller.me>
Co-Authored-By: Christian Neumüller <christian+github@neumueller.me>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, subject to addressing Bogdan's comments regarding having uniform handling for Metrics as well (or a plan for it if it is not addressed in this PR).
Seems like this is ready to merge then? |
@z1c0 please in parallel start two PRs:
|
* First draft: "named tracers" * Implement feedback. * Move named tracers proposal into text folder * Apply suggestions from code review Co-Authored-By: Armin Ruech <armin.ruech@gmail.com> * Apply suggestions from code review Co-Authored-By: Armin Ruech <armin.ruech@gmail.com> * Add examples section. * Update 0000-named-tracers.md * Implement feedback from code review * Remove the implementation details about enabling / disabling ... of sensors and reduced the proposal the actual core of associating names with tracers.:q * Update text/0000-named-tracers.md Co-Authored-By: Christian Neumüller <christian+github@neumueller.me> * Update text/0000-named-tracers.md Co-Authored-By: Christian Neumüller <christian+github@neumueller.me> * Reworked this RFC based on feedback on GitHub. * Implement latest review suggestions * Removed formatting * Re-introduce plain string factory and move Resource-based approach to alternatives * Use ` to format the names in the examples. * Fix typo and broken link * Extended the OTEP to included Metrics as well. * Update text/0000-named-tracers.md Co-Authored-By: Christian Neumüller <christian+github@neumueller.me> * Update text/0000-named-tracers.md Co-Authored-By: Christian Neumüller <christian+github@neumueller.me> * Implement latest feedback. * Rename 0000-named-tracers.md to 0016-named-tracers.md
* First draft: "named tracers" * Implement feedback. * Move named tracers proposal into text folder * Apply suggestions from code review Co-Authored-By: Armin Ruech <armin.ruech@gmail.com> * Apply suggestions from code review Co-Authored-By: Armin Ruech <armin.ruech@gmail.com> * Add examples section. * Update 0000-named-tracers.md * Implement feedback from code review * Remove the implementation details about enabling / disabling ... of sensors and reduced the proposal the actual core of associating names with tracers.:q * Update text/0000-named-tracers.md Co-Authored-By: Christian Neumüller <christian+github@neumueller.me> * Update text/0000-named-tracers.md Co-Authored-By: Christian Neumüller <christian+github@neumueller.me> * Reworked this RFC based on feedback on GitHub. * Implement latest review suggestions * Removed formatting * Re-introduce plain string factory and move Resource-based approach to alternatives * Use ` to format the names in the examples. * Fix typo and broken link * Extended the OTEP to included Metrics as well. * Update text/0000-named-tracers.md Co-Authored-By: Christian Neumüller <christian+github@neumueller.me> * Update text/0000-named-tracers.md Co-Authored-By: Christian Neumüller <christian+github@neumueller.me> * Implement latest feedback. * Rename 0000-named-tracers.md to 0016-named-tracers.md
* First draft: "named tracers" * Implement feedback. * Move named tracers proposal into text folder * Apply suggestions from code review Co-Authored-By: Armin Ruech <armin.ruech@gmail.com> * Apply suggestions from code review Co-Authored-By: Armin Ruech <armin.ruech@gmail.com> * Add examples section. * Update 0000-named-tracers.md * Implement feedback from code review * Remove the implementation details about enabling / disabling ... of sensors and reduced the proposal the actual core of associating names with tracers.:q * Update text/0000-named-tracers.md Co-Authored-By: Christian Neumüller <christian+github@neumueller.me> * Update text/0000-named-tracers.md Co-Authored-By: Christian Neumüller <christian+github@neumueller.me> * Reworked this RFC based on feedback on GitHub. * Implement latest review suggestions * Removed formatting * Re-introduce plain string factory and move Resource-based approach to alternatives * Use ` to format the names in the examples. * Fix typo and broken link * Extended the OTEP to included Metrics as well. * Update text/0000-named-tracers.md Co-Authored-By: Christian Neumüller <christian+github@neumueller.me> * Update text/0000-named-tracers.md Co-Authored-By: Christian Neumüller <christian+github@neumueller.me> * Implement latest feedback. * Rename 0000-named-tracers.md to 0016-named-tracers.md
* First draft: "named tracers" * Implement feedback. * Move named tracers proposal into text folder * Apply suggestions from code review Co-Authored-By: Armin Ruech <armin.ruech@gmail.com> * Apply suggestions from code review Co-Authored-By: Armin Ruech <armin.ruech@gmail.com> * Add examples section. * Update 0000-named-tracers.md * Implement feedback from code review * Remove the implementation details about enabling / disabling ... of sensors and reduced the proposal the actual core of associating names with tracers.:q * Update text/0000-named-tracers.md Co-Authored-By: Christian Neumüller <christian+github@neumueller.me> * Update text/0000-named-tracers.md Co-Authored-By: Christian Neumüller <christian+github@neumueller.me> * Reworked this RFC based on feedback on GitHub. * Implement latest review suggestions * Removed formatting * Re-introduce plain string factory and move Resource-based approach to alternatives * Use ` to format the names in the examples. * Fix typo and broken link * Extended the OTEP to included Metrics as well. * Update text/0000-named-tracers.md Co-Authored-By: Christian Neumüller <christian+github@neumueller.me> * Update text/0000-named-tracers.md Co-Authored-By: Christian Neumüller <christian+github@neumueller.me> * Implement latest feedback. * Rename 0000-named-tracers.md to 0016-named-tracers.md
No description provided.