Threshold propagation in trace state #235

kentquirk · 2023-08-09T22:39:00Z

This is intended to capture the proposal developed by the Sampling SIG.

text/trace/0235-sampling-threshold-in-trace-state.md

oertl · 2023-09-06T13:19:11Z

Currently, everything is very weakly worded, because the text contains many SHALLs and SHOULDs. Shouldn't we be stricter and require that any compliant consistent sampler implementation MUST follow all the rules defined here?

text/trace/0235-sampling-threshold-in-trace-state.md

kentquirk · 2023-09-06T20:22:03Z

@oertl According to this RFC https://www.[ietf.org/rfc/rfc2119.txt](https://www.ietf.org/rfc/rfc2119.txt), MUST and SHALL are equivalent. I thought I had read a document that said to prefer SHALL, but now I can't find it, and I'm finding lots of other ones that prefer MUST, so yeah, I've changed it.

I've tried to address most of the comments.

text/trace/0235-sampling-threshold-in-trace-state.md

Co-authored-by: Armin Ruech <7052238+arminru@users.noreply.github.com>

text/trace/0235-sampling-threshold-in-trace-state.md

Co-authored-by: Armin Ruech <7052238+arminru@users.noreply.github.com>

jmacd · 2024-01-30T17:08:43Z

Thank you @kentquirk!

…rt OTEP 235) (#31894) **Description:** Creates new sampler modes named "equalizing" and "proportional". Preserves existing functionality under the mode named "hash_seed". Fixes #31918 This is the final step in a sequence, the whole of this work was factored into 3+ PRs, including the new `pkg/sampling` and the previous step, #31946. The two new Sampler modes enable mixing OTel sampling SDKs with Collectors in a consistent way. The existing hash_seed mode is also a consistent sampling mode, which makes it possible to have a 1:1 mapping between its decisions and the OTEP 235 randomness and threshold values. Specifically, the 14-bit hash value and sampling probability are mapped into 56-bit R-value and T-value encodings, so that all sampling decisions in all modes include threshold information. This implements the semantic conventions of open-telemetry/semantic-conventions#793, namely the `sampling.randomness` and `sampling.threshold` attributes used for logs where there is no tracestate. The default sampling mode remains HashSeed. We consider a future change of default to Proportional to be desirable, because: 1. Sampling probability is the same, only the hashing algorithm changes 2. Proportional respects and preserves information about earlier sampling decisions, which HashSeed can't do, so it has greater interoperability with OTel SDKs which may also adopt OTEP 235 samplers. **Link to tracking Issue:** Draft for open-telemetry/opentelemetry-specification#3602. Previously #24811, see also open-telemetry/oteps#235 Part of #29738 **Testing:** New testing has been added. **Documentation:** ✅ --------- Co-authored-by: Juraci Paixão Kröhling <juraci.github@kroehling.de>

This is intended to capture the proposal developed by [the Sampling SIG](https://docs.google.com/document/d/1gASMhmxNt9qCa8czEMheGlUW2xpORiYoD7dBD7aNtbQ/edit#heading=h.mngoctm0c84w). --------- Co-authored-by: Joshua MacDonald <jmacd@users.noreply.github.com> Co-authored-by: Spencer Wilson <5624115+spencerwilson@users.noreply.github.com> Co-authored-by: Otmar Ertl <otmar.ertl@gmail.com> Co-authored-by: Armin Ruech <7052238+arminru@users.noreply.github.com>

First draft of threshold propagation proposal

3502d8b

PeterF778 reviewed Aug 10, 2023

View reviewed changes

text/trace/0235-sampling-threshold-in-trace-state.md Outdated Show resolved Hide resolved

oertl reviewed Aug 10, 2023

View reviewed changes

text/trace/0235-sampling-threshold-in-trace-state.md Outdated Show resolved Hide resolved

oertl reviewed Aug 10, 2023

View reviewed changes

text/trace/0235-sampling-threshold-in-trace-state.md Outdated Show resolved Hide resolved

text/trace/0235-sampling-threshold-in-trace-state.md Outdated Show resolved Hide resolved

kentquirk added 3 commits August 31, 2023 10:05

Respond to feedback.

0369c35

appease linter

8c84f4d

One more linty list

e8e0496

jmacd self-requested a review August 31, 2023 15:07

kentquirk marked this pull request as ready for review September 5, 2023 12:57

kentquirk requested review from a team September 5, 2023 12:57

kentquirk changed the title ~~First draft of threshold propagation proposal~~ Threshold propagation in trace state Sep 5, 2023

yurishkuro reviewed Sep 5, 2023

View reviewed changes

text/trace/0235-sampling-threshold-in-trace-state.md Outdated Show resolved Hide resolved

yurishkuro reviewed Sep 5, 2023

View reviewed changes

text/trace/0235-sampling-threshold-in-trace-state.md Outdated Show resolved Hide resolved

yurishkuro reviewed Sep 5, 2023

View reviewed changes

text/trace/0235-sampling-threshold-in-trace-state.md Outdated Show resolved Hide resolved

yurishkuro reviewed Sep 5, 2023

View reviewed changes

text/trace/0235-sampling-threshold-in-trace-state.md Outdated Show resolved Hide resolved

yurishkuro reviewed Sep 5, 2023

View reviewed changes

text/trace/0235-sampling-threshold-in-trace-state.md Show resolved Hide resolved

PeterF778 reviewed Sep 6, 2023

View reviewed changes

text/trace/0235-sampling-threshold-in-trace-state.md Outdated Show resolved Hide resolved

jpkrohling reviewed Sep 6, 2023

View reviewed changes

text/trace/0235-sampling-threshold-in-trace-state.md Outdated Show resolved Hide resolved

text/trace/0235-sampling-threshold-in-trace-state.md Outdated Show resolved Hide resolved

oertl reviewed Sep 6, 2023

View reviewed changes

jmacd mentioned this pull request Sep 6, 2023

Non-power-of-two consistent tail probability sampling in TraceState #226

Closed

Respond to feedback

23b0bea

kentquirk added 3 commits September 6, 2023 16:23

Remove embedded question.

6866873

sampled flag

f3fc7c2

lint

5a9e0d9

pyohannes reviewed Sep 6, 2023

View reviewed changes

text/trace/0235-sampling-threshold-in-trace-state.md Outdated Show resolved Hide resolved

yurishkuro reviewed Sep 6, 2023

View reviewed changes

text/trace/0235-sampling-threshold-in-trace-state.md Outdated Show resolved Hide resolved

kalyanaj reviewed Sep 6, 2023

View reviewed changes

text/trace/0235-sampling-threshold-in-trace-state.md Outdated Show resolved Hide resolved

text/trace/0235-sampling-threshold-in-trace-state.md Outdated Show resolved Hide resolved

text/trace/0235-sampling-threshold-in-trace-state.md Outdated Show resolved Hide resolved

pyohannes mentioned this pull request Jan 24, 2024

Automatic propagation of peer.service #247

Closed

arminru reviewed Jan 25, 2024

View reviewed changes

kentquirk and others added 5 commits January 25, 2024 11:13

Update text/trace/0235-sampling-threshold-in-trace-state.md

50d105f

Co-authored-by: Armin Ruech <7052238+arminru@users.noreply.github.com>

Update text/trace/0235-sampling-threshold-in-trace-state.md

4d262b4

Co-authored-by: Armin Ruech <7052238+arminru@users.noreply.github.com>

Update text/trace/0235-sampling-threshold-in-trace-state.md

91af1f4

Co-authored-by: Armin Ruech <7052238+arminru@users.noreply.github.com>

Update text/trace/0235-sampling-threshold-in-trace-state.md

29e322b

Co-authored-by: Armin Ruech <7052238+arminru@users.noreply.github.com>

Update text/trace/0235-sampling-threshold-in-trace-state.md

dcda3c1

Co-authored-by: Armin Ruech <7052238+arminru@users.noreply.github.com>

arminru reviewed Jan 25, 2024

View reviewed changes

text/trace/0235-sampling-threshold-in-trace-state.md Outdated Show resolved Hide resolved

arminru approved these changes Jan 25, 2024

View reviewed changes

kentquirk and others added 3 commits January 25, 2024 12:46

respond to feedback

e790133

Update text/trace/0235-sampling-threshold-in-trace-state.md

88bcd53

Co-authored-by: Armin Ruech <7052238+arminru@users.noreply.github.com>

Merge branch 'main' into threshold-propagation

053df85

jmacd merged commit 4d54d97 into open-telemetry:main Jan 30, 2024
2 checks passed

jmacd mentioned this pull request Feb 27, 2024

Probability Samplers based on W3C Trace Context Level 2 open-telemetry/opentelemetry-specification#3910

Closed

5 tasks

jmacd mentioned this pull request Mar 21, 2024

[probabilistic sampling processor] encoded sampling probability (support OTEP 235) open-telemetry/opentelemetry-collector-contrib#31894

Merged

jmacd mentioned this pull request Apr 24, 2024

Project Tracking: Sampling open-telemetry/opentelemetry-specification#4012

Open

codeboten deleted the threshold-propagation branch July 16, 2024 15:48

This was referenced Jul 25, 2024

Randomness requirements following W3C Trace Context level 2 open-telemetry/opentelemetry-specification#4162

Draft

OpenTelemetry TraceIdRatioBased sampler requirements following OTEP 235 open-telemetry/opentelemetry-specification#4166

Draft

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Threshold propagation in trace state #235

Threshold propagation in trace state #235

kentquirk commented Aug 9, 2023 •

edited

Loading

oertl commented Sep 6, 2023

kentquirk commented Sep 6, 2023

jmacd commented Jan 30, 2024

Threshold propagation in trace state #235

Threshold propagation in trace state #235

Conversation

kentquirk commented Aug 9, 2023 • edited Loading

oertl commented Sep 6, 2023

kentquirk commented Sep 6, 2023

jmacd commented Jan 30, 2024

kentquirk commented Aug 9, 2023 •

edited

Loading