Skip to content
This repository has been archived by the owner on Nov 21, 2024. It is now read-only.

Remote write compliance: TestRemoteWrite/otelcollector/InstanceLabel #39

Closed
rakyll opened this issue Apr 20, 2021 · 0 comments · Fixed by open-telemetry/opentelemetry-collector#2979
Closed

Remote write compliance: TestRemoteWrite/otelcollector/InstanceLabel #39

rakyll opened this issue Apr 20, 2021 · 0 comments · Fixed by open-telemetry/opentelemetry-collector#2979
Assignees
@rakyll
Labels
P0 An issue that needs to be addressed immediately. Breaking change. phase1 phase1 tasks prom-exporter Prometheus exporter tasks
Milestone
Phase 1 Implement...

Comments

@rakyll
Copy link
Contributor

rakyll commented Apr 20, 2021

The OpenTelemetry collector is not passing https://github.com/prometheus/compliance/tree/main/remote_write
TestRemoteWrite/otelcollector/InstanceLabel.

=== CONT  TestRemoteWrite/otelcollector/InstanceLabel
    helpers.go:21:
        	Error Trace:	helpers.go:21
        	            				helpers.go:52
        	            				helpers.go:13
        	            				instance_label.go:26
        	            				main_test.go:101
        	            				main_test.go:65
        	Error:      	Should be true
        	Test:       	TestRemoteWrite/otelcollector/InstanceLabel
        	Messages:   	label 'instance' not found
@rakyll rakyll changed the title Remote write compatibility: TestRemoteWrite/otelcollector/InstanceLabel Remote write compliance: TestRemoteWrite/otelcollector/InstanceLabel Apr 20, 2021
@rakyll rakyll added phase1 phase1 tasks prom-exporter Prometheus exporter tasks P0 An issue that needs to be addressed immediately. Breaking change. labels Apr 20, 2021
This was referenced Apr 20, 2021
Closed
Closed
@rakyll rakyll self-assigned this Apr 20, 2021
@rakyll rakyll mentioned this issue Apr 21, 2021
Merged
bogdandrutu pushed a commit to open-telemetry/opentelemetry-collector that referenced this issue Apr 22, 2021
@rakyll
Don't drop instance and job labels in the Prometheus Remote Write Exp…
33f9a24 
…orter (#2979)

This is a follow up to #2897.

Fixes #575
Fixes #2499
Fixes #2363
Fixes open-telemetry/prometheus-interoperability-spec#37
Fixes open-telemetry/prometheus-interoperability-spec#39
Fixes open-telemetry/prometheus-interoperability-spec#44

Passing compliance tests:

$ go test --tags=compliance -run "TestRemoteWrite/otelcollector/Job.+" -v ./
=== RUN TestRemoteWrite
=== RUN TestRemoteWrite/otelcollector
=== RUN TestRemoteWrite/otelcollector/JobLabel
=== PAUSE TestRemoteWrite/otelcollector/JobLabel
=== CONT TestRemoteWrite/otelcollector/JobLabel
--- PASS: TestRemoteWrite (10.02s)
--- PASS: TestRemoteWrite/otelcollector (0.00s)
--- PASS: TestRemoteWrite/otelcollector/JobLabel (10.02s)
PASS
ok github.com/prometheus/compliance/remote_write 10.382s
$ go test --tags=compliance -run "TestRemoteWrite/otelcollector/Instance.+" -v ./
=== RUN TestRemoteWrite
=== RUN TestRemoteWrite/otelcollector
=== RUN TestRemoteWrite/otelcollector/InstanceLabel
=== PAUSE TestRemoteWrite/otelcollector/InstanceLabel
=== CONT TestRemoteWrite/otelcollector/InstanceLabel
--- PASS: TestRemoteWrite (10.01s)
--- PASS: TestRemoteWrite/otelcollector (0.00s)
--- PASS: TestRemoteWrite/otelcollector/InstanceLabel (10.01s)
PASS
ok github.com/prometheus/compliance/remote_write 10.291s
$ go test --tags=compliance -run "TestRemoteWrite/otelcollector/RepeatedLabels.+" -v ./
=== RUN TestRemoteWrite
=== RUN TestRemoteWrite/otelcollector
--- PASS: TestRemoteWrite (0.00s)
--- PASS: TestRemoteWrite/otelcollector (0.00s)
testing: warning: no tests to run
PASS
@alolita alolita added this to the Phase 1 Implementation milestone Jun 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rakyll rakyll

Labels
P0 An issue that needs to be addressed immediately. Breaking change. phase1 phase1 tasks prom-exporter Prometheus exporter tasks
Projects
None yet
Milestone
Phase 1 Implementation
2 participants
@rakyll @alolita