Skip to content

Commit

Permalink
Require two approvals from different companies before merging the PR (#…
Browse files Browse the repository at this point in the history
…364)

Co-authored-by: Alexander Wert <AlexanderWert@users.noreply.github.com>
  • Loading branch information
reyang and AlexanderWert authored Oct 9, 2023
1 parent 0af7e0e commit 4efa49f
Showing 1 changed file with 17 additions and 0 deletions.
17 changes: 17 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,23 @@ To quickly fix typos, use
make misspell-correction
```

### How to get your PR merged

A PR (pull request) is considered to be **ready to merge** when:

* It has received at least two approvals from the [code
owners](./.github/CODEOWNERS) (if approvals are from only one company, they
won't count).
* There is no `request changes` from the [code owners](./.github/CODEOWNERS).
* It has been at least two working days since the last modification (except for
the trivial updates, such like typo, cosmetic, rebase, etc.). This gives
people reasonable time to review.
* Trivial changes (typos, cosmetic changes, CI improvements, etc.) don't have to
wait for two days.

Any [maintainer](./README.md#contributing) can merge the PR once it is **ready
to merge**.

## Updating the referenced specification version

1. Open the `./internal/tools/update_specification_version.sh` script.
Expand Down

0 comments on commit 4efa49f

Please sign in to comment.