Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] Use group name for generating snippets #1049

Merged
merged 3 commits into from
May 21, 2024
Merged

[chore] Use group name for generating snippets #1049

merged 3 commits into from
May 21, 2024

Conversation

trisch-me
Copy link
Contributor

@trisch-me trisch-me commented May 17, 2024 •
edited
Loading

@jsuereth this fixes issue from hardware PR #1030 when naming for md files was incorrectly taken from prefix
I push lineage to the macro and extract needed information from it

Merge requirement checklist

@trisch-me trisch-me requested review from a team May 17, 2024 19:49
@trisch-me trisch-me mentioned this pull request May 21, 2024
Merged
3 tasks
@reyang reyang merged commit ab96615 into open-telemetry:main May 21, 2024
12 checks passed
drewby pushed a commit to drewby/otel-semantic-conventions that referenced this pull request May 23, 2024
@trisch-me @drewby
[chore] Use group name for generating snippets (open-telemetry#1049)
26fa595
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsuereth jsuereth jsuereth approved these changes

@trask trask trask approved these changes

@lquerel lquerel lquerel approved these changes

@arminru arminru arminru approved these changes

Assignees

@arminru arminru

Labels
None yet
Projects
Semantic Conventions Triage
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@trisch-me @jsuereth @trask @lquerel @arminru @reyang