Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved HTTP semantic conventions to a dedicated topic-based structure #141

Merged
merged 6 commits into from
Jun 28, 2023

Conversation

AlexanderWert
Copy link
Member

Part of #137

  • created /specification/README.md as a single entry point for all of the semantic conventions (for easier to consumption in the website)
  • created specification/http/README.md as an entry point for HTTP semantic conventions
  • moved HTTP conventions for spans and metrics to specification/http/
  • updated references and links

New structure for HTTP semantic conventions:

┬ specification
├─ README.md
└─ http
    ├─ README.md
    ├─ http-spans.md
    └─ http-metrics.md

Signed-off-by: Alexander Wert <alexander.wert@elastic.co>
@AlexanderWert AlexanderWert requested review from a team June 27, 2023 13:37
Signed-off-by: Alexander Wert <alexander.wert@elastic.co>
Signed-off-by: Alexander Wert <alexander.wert@elastic.co>
Copy link
Contributor

@jsuereth jsuereth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. However, looking at this, I'm curious if maybe we should go after "general" conventions first (or next). WDYT?

specification/README.md Outdated Show resolved Hide resolved
specification/README.md Outdated Show resolved Hide resolved
specification/http/http-metrics.md Outdated Show resolved Hide resolved
specification/http/README.md Outdated Show resolved Hide resolved
specification/README.md Outdated Show resolved Hide resolved
specification/http/http-spans.md Outdated Show resolved Hide resolved
Signed-off-by: Alexander Wert <alexander.wert@elastic.co>
@joaopgrassi
Copy link
Member

joaopgrassi commented Jun 27, 2023

.. I'm curious if maybe we should go after "general" conventions first (or next). WDYT?

Maybe bring "general" ones while bringing the ones that mostly use it? For ex, bring http-general as part of this, since we are moving http conventions which uses the bulk of general attributes?

@joaopgrassi
Copy link
Member

It is happening! 🎉

@AlexanderWert
Copy link
Member Author

.. I'm curious if maybe we should go after "general" conventions first (or next). WDYT?

Maybe bring "general" ones while bringing the ones that mostly use it? For ex, bring http-general as part of this, since we are moving http conventions which uses the bulk of general attributes?

@joaopgrassi What do you mean by http-general? I think, we do not have such a thing, yet. Or do you mean moving span-general.md as part of this PR as well because HTTP refers to many attributes from span-general.md?

@AlexanderWert
Copy link
Member Author

I can do general next (tomorrow).

specification/README.md Outdated Show resolved Hide resolved
@joaopgrassi
Copy link
Member

@AlexanderWert

What do you mean by http-general? I think, we do not have such a thing, yet. Or do you mean moving span-general.md as part of this PR as well because HTTP refers to many attributes from span-general.md?

Yes, sorry, I meant the span-general.md, not sure where I came from with http-general. All good to do it in a follow up :)

Signed-off-by: Alexander Wert <alexander.wert@elastic.co>
@AlexanderWert
Copy link
Member Author

@arminru Can we merge this? There are other PRs depending on this, so merging this would make it easier to review the other PRs.

@reyang
Copy link
Member

reyang commented Jun 28, 2023

@arminru Can we merge this? There are other PRs depending on this, so merging this would make it easier to review the other PRs.

+1 - let's move forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants