-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moved HTTP semantic conventions to a dedicated topic-based structure #141
Conversation
Signed-off-by: Alexander Wert <alexander.wert@elastic.co>
Signed-off-by: Alexander Wert <alexander.wert@elastic.co>
Signed-off-by: Alexander Wert <alexander.wert@elastic.co>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM. However, looking at this, I'm curious if maybe we should go after "general" conventions first (or next). WDYT?
Signed-off-by: Alexander Wert <alexander.wert@elastic.co>
Maybe bring "general" ones while bringing the ones that mostly use it? For ex, bring |
It is happening! 🎉 |
@joaopgrassi What do you mean by |
I can do |
Yes, sorry, I meant the |
Signed-off-by: Alexander Wert <alexander.wert@elastic.co>
@arminru Can we merge this? There are other PRs depending on this, so merging this would make it easier to review the other PRs. |
+1 - let's move forward. |
Part of #137
/specification/README.md
as a single entry point for all of the semantic conventions (for easier to consumption in the website)specification/http/README.md
as an entry point for HTTP semantic conventionsspecification/http/
New structure for HTTP semantic conventions: