Proposal: Unify metric templates #1411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christophe-kamphaus-jemmic
approved these changes
Sep 16, 2024
joaopgrassi
approved these changes
Sep 17, 2024
5 tasks
christophe-kamphaus-jemmic
added a commit
to christophe-kamphaus-jemmic/semantic-conventions
that referenced
this pull request
Sep 17, 2024
drewby
pushed a commit
to drewby/otel-semantic-conventions
that referenced
this pull request
Oct 1, 2024
Co-authored-by: Joao Grassi <5938087+joaopgrassi@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it so you only need one semconv markdown callout for metrics:
Will now generate both the metric name table and the attribute table.
Given everyone explicitly did this before, you can see it's mostly deleting the extra header that existed previously.
Related (but not fully solving): #1040