Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update enduser domain and add enduser.pseudo.id #1456

Merged
merged 56 commits into from
Feb 3, 2025
Merged

Update enduser domain and add enduser.pseudo.id #1456

merged 56 commits into from
Feb 3, 2025
+79 −80

Conversation

heyams
Copy link
Contributor

@heyams heyams commented Oct 7, 2024

Fixes #1104

@heyams heyams force-pushed the heya/add-enduser-namespace branch from 0a8b0e8 to ee0970f Compare October 7, 2024 19:06
heyams
heyams commented Oct 7, 2024
View reviewed changes
model/enduser/registry.yaml Outdated Show resolved Hide resolved
@lmolkova lmolkova mentioned this pull request Oct 14, 2024
Closed
lmolkova
lmolkova reviewed Oct 14, 2024
View reviewed changes
model/enduser/registry.yaml Outdated Show resolved Hide resolved
model/enduser/registry.yaml Outdated Show resolved Hide resolved
model/enduser/registry.yaml Show resolved Hide resolved
@heyams heyams changed the title Update enduser domain and add authentication as a subdomain Update enduser domain and add enduser.authentication.id Oct 22, 2024
@heyams heyams changed the title Update enduser domain and add enduser.authentication.id Update enduser domain and add enduser.authentication.id Oct 22, 2024
@heyams
Copy link
Contributor Author

heyams commented Oct 23, 2024

need some advice with this weaver error, it didn't point to any files that I have modified. it's persisting.
image

@trask
Copy link
Member

trask commented Oct 23, 2024

need some advice with this weaver error, it didn't point to any files that I have modified. it's persisting. image

if you scroll up from there, you'll see:

ℹ Validating: $/home/weaver/target/general/attributes.md
✖ Could not find: identity

which looks related to this file that was deleted in your PR: model/enduser/deprecated/common.yaml

joaopgrassi
joaopgrassi previously requested changes Oct 29, 2024
View reviewed changes
docs/attributes-registry/authentication.md Outdated Show resolved Hide resolved
@joaopgrassi joaopgrassi mentioned this pull request Oct 29, 2024
Closed
@heyams
Copy link
Contributor Author

heyams commented Jan 24, 2025 •
edited
Loading

@joaopgrassi i don't have permission to dismiss your "request for change". Your comment no longer applied.
please review it again and unblock this PR.

image

@joaopgrassi joaopgrassi dismissed their stale review January 27, 2025 16:12

Dismiss for now, will try to review later.

lmolkova
lmolkova reviewed Jan 28, 2025
View reviewed changes
model/enduser/deprecated/registry-deprecated.yaml Outdated Show resolved Hide resolved
model/enduser/registry.yaml Show resolved Hide resolved
model/enduser/registry.yaml Outdated Show resolved Hide resolved
model/enduser/registry.yaml Show resolved Hide resolved
docs/general/attributes.md Outdated Show resolved Hide resolved
trask
trask reviewed Jan 29, 2025
View reviewed changes
.chloggen/add_enduser_pseudo_id.yaml Outdated Show resolved Hide resolved
docs/general/attributes.md Outdated Show resolved Hide resolved
model/enduser/registry.yaml Outdated Show resolved Hide resolved
trask
trask reviewed Jan 31, 2025
View reviewed changes
docs/general/attributes.md Outdated Show resolved Hide resolved
@heyams heyams requested a review from trask January 31, 2025 20:13
trask
trask reviewed Jan 31, 2025
View reviewed changes
model/enduser/common.yaml Outdated Show resolved Hide resolved
docs/general/attributes.md Show resolved Hide resolved
docs/general/attributes.md Show resolved Hide resolved
@heyams heyams requested a review from MSNev January 31, 2025 21:16
trask
trask approved these changes Jan 31, 2025
View reviewed changes
.chloggen/add_enduser_pseudo_id.yaml Outdated Show resolved Hide resolved
.chloggen/add_enduser_pseudo_id.yaml Outdated Show resolved Hide resolved
jsuereth
jsuereth approved these changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@jsuereth jsuereth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this! I realize it took a long time to get to it.

I do agree with both of trask's rewording suggestions, but otherwise this looks good as is.

@lmolkova lmolkova merged commit 31b9301 into open-telemetry:main Feb 3, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MSNev MSNev MSNev approved these changes

@trisch-me trisch-me trisch-me approved these changes

@lmolkova lmolkova lmolkova approved these changes

@trask trask trask approved these changes

@jsuereth jsuereth jsuereth approved these changes

@joaopgrassi joaopgrassi Awaiting requested review from joaopgrassi

@LikeTheSalad LikeTheSalad Awaiting requested review from LikeTheSalad

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Semantic Conventions Triage
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

User.id for authenticated user id
8 participants
@heyams @trask @trisch-me @jsuereth @lmolkova @joaopgrassi @MSNev @LikeTheSalad