-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Add EventToCarrier to AWS Lambda semantic conventions #164
Closed
rapphil
wants to merge
47
commits into
open-telemetry:main
from
rapphil:rapphil-add-event-to-carrier
Closed
Changes from all commits
Commits
Show all changes
47 commits
Select commit
Hold shift + click to select a range
3aaa4cd
Feat: Add EventToCarrier to AWS Lambda semantic conventions
rapphil 526dc65
Fix: fix TOC
rapphil ab15449
Fix: fix toc
rapphil 8606301
Merge branch 'main' into rapphil-add-event-to-carrier
rapphil 29fdde3
Update specification/faas/aws-lambda.md
rapphil 71f4932
Moved resource semconv directly under the resource directory (#165)
AlexanderWert f4a5387
Renamed `specification` and `semantic_conventions` to `model` and `do…
AlexanderWert 053fe9a
Fix path of md table generation make task (#173)
joaopgrassi 86940d2
Add markdown file for url semantic conventions (#174)
ChrsMark c2b9767
[editorial] Add missing `README.md` for Resource Cloud Provider semco…
chalin 02071de
[editorial] docs/rpc/json-rpc: fix title and in-page hypenation (#170)
chalin 57bd011
[editorial] Rename docs files and folders: replace "_" by "-"; add ch…
chalin c35b1d4
Fix semantic-conventions README.md file links (#168)
YANG-DB aa85e62
[editorial] Fix doc page titles and add Hugo front matter (#175)
chalin 31ca6ef
[editorial] Link directly to page, not to page's title (#180)
chalin f875722
Bump to latest version of the specification. (#185)
jsuereth 5200be9
[CI] Report link-check error when external URL used for local doc pag…
chalin 69f6bae
Update documentation for how to cut a release AND perform the action …
jsuereth 12bd6b0
[editorial] markdownlint in less then 1.5 sec (#193)
chalin b7e10e6
[editorial] Rename general section pages by dropping `general` from t…
chalin 89e1603
[editorial] Setup Prettier and run it on some files (#192)
chalin c31e03c
Editorial: Remove overlooked messaging.source attributes from aws lam…
lmolkova de2cf45
Fix the unit of metric.process.runtime.jvm.system.cpu.load_1m to be {…
zeitlinger be82642
Change company affiliation for Johannes (#207)
pyohannes fe818fd
`.count` metric naming convention only applies to UpDownCounters (#107)
trask 97e92be
[editorial][CI] Ensure markdownlint has proper exit status (#210)
chalin c4b58a4
Update contributing documentation for restructuring of repository (#216)
jsuereth a46db0f
Re-enable the schema check to look at the website. (#217)
jsuereth 1c4e58f
Add Alexander Wert as an Approver (#220)
reyang ff064a4
Bump semantic conventions tooling to v0.20.0 (#225)
arminru 0cf0e8d
Add system.cpu.physical.count and system.cpu.logical.count metrics (#99)
frzifus 740ebd6
Add PR template (#223)
reyang 6561f68
Generate database metrics semconv from YAML (#90)
joaopgrassi a491f82
Generate RPC metrics from YAML (#93)
joaopgrassi 790eac9
Rename `http.*.duration` to `http.*.request.duration` (#224)
lmolkova 2f4d8b4
HTTP version should be 2 and 3 instead of 2.0 and 3.0 (#228)
lmolkova 94b653e
Generate FaaS metrics semconv from YAML (#88)
joaopgrassi 8dfd92c
Re-introduce namespace to describe the original destination (#156)
joaopgrassi 50cf594
Move Joao Grassi from approver to maintainer (#239)
reyang d550c98
Update destination attribute briefs (#243)
trask a6c3202
Rename all JVM metrics from process.runtime.jvm.* to jvm.* (#241)
trask 92ad618
Fix: fix TOC
rapphil 1d3b5ca
Fix: fix toc
rapphil 58c722c
Update EvenToCarrier based on feedback
rapphil 7fd5a23
Merge branch 'main' into rapphil-add-event-to-carrier
rapphil 94a3bf5
Update to simplify language
rapphil 6dd68fe
Merge branch 'main' into rapphil-add-event-to-carrier
rapphil File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't take @Oberon00's feedback into account. As written, it seems that SQS lambda's will require explicit config to select the proper
EventToCarrier
implementation. This should not be required of users.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, is there anything in the proposal blocking the implementation of a
EventToCarrier
that is supposed to work with SQS? I don't think we need to list all possible cases and how they should be implemented, do we?The important thing is that the lambda instrumentation can receive an
EventToCarrier
as parameter.Listing cases that COULD be supported was a source of confusion in the previous revision of this proposal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem is not missing cases, but that the user should not need to configure this explicitly. The implementation should automatically extract without the user configuring the trigger type explicitly.