Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renamed specification and semantic_conventions to model and docs #166

Merged
merged 1 commit into from
Jul 6, 2023
Merged

Renamed specification and semantic_conventions to model and docs #166

merged 1 commit into from
Jul 6, 2023

Conversation

AlexanderWert
Copy link
Member

This is an alternative implementation of #161 based on the proposal in this comment.

Here:

  • specification -> docs
  • semantic_conventions -> model

@AlexanderWert AlexanderWert requested review from a team July 6, 2023 15:40
@AlexanderWert AlexanderWert requested a review from a team July 6, 2023 15:40
@AlexanderWert AlexanderWert mentioned this pull request Jul 6, 2023
Closed
@AlexanderWert AlexanderWert force-pushed the md-restruct-rename-docs branch from 66f7708 to 037e793 Compare July 6, 2023 17:50
@AlexanderWert
renamed specification and semantic_conventions directories
bf061d6 
Signed-off-by: Alexander Wert <alexander.wert@elastic.co>
@AlexanderWert AlexanderWert force-pushed the md-restruct-rename-docs branch from 037e793 to bf061d6 Compare July 6, 2023 17:52
jsuereth
jsuereth approved these changes Jul 6, 2023
View reviewed changes
Copy link
Contributor

@jsuereth jsuereth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be ok with this change prior to release.

We would need to do the following:

  1. Update the opentelemetry.io integration.
  2. Warn/provide guidance to EVERY codegen user out there that the semconv directory has changed and new directions for codegen.

reyang
reyang approved these changes Jul 6, 2023
View reviewed changes
Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I support this change since it brings more clarity.

@reyang reyang merged commit 4142dd3 into open-telemetry:main Jul 6, 2023
@jorgeepc jorgeepc mentioned this pull request Jul 6, 2023
Merged
4 tasks
@chalin
Copy link
Contributor

chalin commented Jul 6, 2023

@jsuereth et al. - I'll work on the OTel website to bring in these changes as soon as I can.

@chalin chalin mentioned this pull request Jul 6, 2023
Merged
rapphil pushed a commit to rapphil/semantic-conventions that referenced this pull request Aug 14, 2023
@AlexanderWert @rapphil
Renamed specification and semantic_conventions to model and `do…
f4a5387 
…cs` (open-telemetry#166)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reyang reyang reyang approved these changes

@jsuereth jsuereth jsuereth approved these changes

@tigrannajaryan tigrannajaryan Awaiting requested review from tigrannajaryan tigrannajaryan is a code owner

Assignees

@jsuereth jsuereth

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AlexanderWert @chalin @jsuereth @reyang