Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[editorial] Rename docs files and folders: replace "_" by "-"; add check #177

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@ jobs:
- name: install dependencies
run: npm install

- name: Check file and folder names
run: make check-file-and-folder-names-in-docs
arminru marked this conversation as resolved.
Show resolved Hide resolved

- name: run markdownlint
run: make markdownlint

Expand Down
12 changes: 11 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,17 @@ SEMCONVGEN_VERSION=0.18.0

# TODO: add `yamllint` step to `all` after making sure it works on Mac.
.PHONY: all
all: install-tools markdownlint markdown-link-check misspell table-check schema-check
all: install-tools markdownlint markdown-link-check misspell table-check schema-check \
check-file-and-folder-names-in-docs

.PHONY: check-file-and-folder-names-in-docs
check-file-and-folder-names-in-docs:
@found=`find docs -name '*_*'`; \
if [ -n "$$found" ]; then \
echo "Error: Underscores found in doc file or folder names, use hyphens instead:"; \
echo $$found; \
exit 1; \
fi

$(MISSPELL):
cd $(TOOLS_DIR) && go build -o $(MISSPELL_BINARY) github.com/client9/misspell/cmd/misspell
Expand Down
10 changes: 5 additions & 5 deletions docs/resource/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ Attributes defining a running environment (e.g. Operating System, Cloud, Data Ce
- [Device](./device.md)
- [Cloud](./cloud.md)
- Deployment:
- [Deployment Environment](./deployment_environment.md)
- [Deployment Environment](./deployment-environment.md)
- [Kubernetes](./k8s.md)
- [Browser](./browser.md)

Expand All @@ -216,14 +216,14 @@ the exact version used to identify an artifact. This may be a semantic version,

Attributes that are only applicable to resources from a specific cloud provider. Currently, these
resources can only be defined for providers listed as a valid `cloud.provider` in
[Cloud](./cloud.md) and below. Provider-specific attributes all reside in the `cloud_provider` directory.
[Cloud](./cloud.md) and below. Provider-specific attributes all reside in the `cloud-provider` directory.
Valid cloud providers are:

- [Alibaba Cloud](https://www.alibabacloud.com/) (`alibaba_cloud`)
- [Amazon Web Services](https://aws.amazon.com/) ([`aws`](cloud_provider/aws/README.md))
- [Google Cloud Platform](https://cloud.google.com/) ([`gcp`](cloud_provider/gcp/README.md))
- [Amazon Web Services](https://aws.amazon.com/) ([`aws`](cloud-provider/aws/README.md))
- [Google Cloud Platform](https://cloud.google.com/) ([`gcp`](cloud-provider/gcp/README.md))
- [Microsoft Azure](https://azure.microsoft.com/) (`azure`)
- [Tencent Cloud](https://www.tencentcloud.com/) (`tencent_cloud`)
- [Heroku dyno](./cloud_provider/heroku.md)
- [Heroku dyno](./cloud-provider/heroku.md)

[DocumentStatus]: https://github.com/open-telemetry/opentelemetry-specification/blob/v1.21.0/specification/document-status.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ provider (like account ID, operating system, etc), it belongs in the parent

## Services

- [Cloud Run](./cloud_run.md)
- [Cloud Run](./cloud-run.md)
- [Compute Engine](./gce.md)

[DocumentStatus]: https://github.com/open-telemetry/opentelemetry-specification/blob/v1.21.0/specification/document-status.md