Moved template attributes to yaml model files #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
approved these changes
Sep 13, 2023
AlexanderWert
force-pushed
the
attribute-templates
branch
from
03812ea to
d1a2f5c
Compare
Signed-off-by: Alexander Wert <alexander.wert@elastic.co> fixed toc Signed-off-by: Alexander Wert <alexander.wert@elastic.co> Update model/trace/http.yaml Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
AlexanderWert
force-pushed
the
attribute-templates
branch
from
d1a2f5c to
d75984f
Compare
|
@open-telemetry/specs-semconv-maintainers Can we get this refactoring in before the next release, please? This would allow to start writing code generator templates for the different SDKs for the template type attributes. @open-telemetry/specs-semconv-approvers We also need more reviews. |
joaopgrassi
approved these changes
Sep 21, 2023
trask
added
the
ready-to-merge
lmolkova
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With open-telemetry/build-tools#186, template attributes (such as
http.request.header.<key>) can be defined in the YAML model files (instead of defining them in the markdown files).This PR moves existing template attributes into the yaml files.