Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the zero bucket boundary from http.server.request.duration and http.client.request.duration #318

Merged
merged 4 commits into from
Sep 26, 2023

Conversation

trask
Copy link
Member

@trask trask commented Sep 12, 2023

Fixes #298

Changes

Removes the zero bucket boundary from http.server.request.duration and http.client.request.duration.

Merge requirement checklist

@trask trask marked this pull request as ready for review September 12, 2023 20:19
@trask trask requested review from a team September 12, 2023 20:19
@reyang reyang merged commit 9790d8f into open-telemetry:main Sep 26, 2023
9 checks passed
@trask trask deleted the http-duration-buckets branch September 26, 2023 17:05
@JamesNK
Copy link

JamesNK commented Nov 2, 2023

After this change, it's odd that the default buckets - https://github.com/open-telemetry/opentelemetry-specification/blob/7a7b36e88742f834c1097cc7f1c1d13182cb1142/specification/metrics/sdk.md#explicit-bucket-histogram-aggregation - have zero, and this one doesn't.

Also, the number of buckets is now inconsistent between these durations and the defaults. It was easy to reason that these buckets were simply the defaults but adjusted to seconds.

@trask
Copy link
Member Author

trask commented Nov 2, 2023

my interpretation of the default buckets is that they are (sadly) just a legacy artifact, and are pretty meaningless now that the default unit has changed to seconds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should HTTP duration metrics include bucket boundary of zero?
10 participants