Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove experimental Kafka metrics #338

Merged

Conversation

pyohannes
Copy link
Contributor

@pyohannes pyohannes commented Sep 21, 2023

Fixes #269

Changes

Based on a discussion in the semantic conventions SIG, this PR removes experimental Kafka metrics from the semantic conventions.

Reasons:

  • The metrics in question were JMX specific, a different set of metrics is provided by other clients like e. g. Samara.
  • Kafka folks currently have no intent maintaining a definition of Kafka broker metrics as part of OpenTelemetry semantic conventions.
  • For very specific metrics, we'd like to encourage maintaining a definition of those metrics as part of the package that produces those metrics. For Kafka broker metrics, such a definition already seems to be available as part of the kafkametricsreceiver collector component.

Merge requirement checklist

@pyohannes pyohannes requested review from a team September 21, 2023 14:23
@reyang reyang merged commit 6166960 into open-telemetry:main Sep 21, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move existing Kafka metrics to a JMX specific namespace
6 participants