Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move runtime semconv to its own folder #371

Merged
merged 4 commits into from
Oct 9, 2023
Merged

Move runtime semconv to its own folder #371

merged 4 commits into from
Oct 9, 2023

Conversation

joaopgrassi
Copy link
Member

Fixes #370

Changes

  • Fixes outdated guidelines for runtime environment metrics namespace Runtime environment metrics namespace guideline is outdated #370
  • Move the jvm-metrics.md to a runtime folder, where other runtime metrics can later be added. (e.g. nodejs)
  • Re-organize the README to make it similar to other folders (not only metrics, but traces and logs)

Merge requirement checklist

cc @trask @open-telemetry/java-instrumentation-approvers

@joaopgrassi joaopgrassi requested review from a team October 6, 2023 13:01
@jsuereth jsuereth merged commit 559bf8b into open-telemetry:main Oct 9, 2023
8 checks passed
@joaopgrassi joaopgrassi deleted the reorganize-runtime-semconv branch October 9, 2023 13:32
@laurit laurit mentioned this pull request Oct 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reyang reyang reyang approved these changes

@ChrsMark ChrsMark ChrsMark approved these changes

@mx-psi mx-psi mx-psi approved these changes

@AlexanderWert AlexanderWert AlexanderWert approved these changes

Assignees

@arminru arminru

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Runtime environment metrics namespace guideline is outdated
7 participants
@joaopgrassi @AlexanderWert @mx-psi @ChrsMark @reyang @jsuereth @arminru