Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make server.port conditionally required on HTTP server semconv #399

Conversation

trask
Copy link
Member

@trask trask commented Oct 12, 2023

Part of #385

Changes

Makes server.port conditionally required on HTTP server semconv when it is not the default for the given url.scheme (80/443).

This avoids the question of whether missing server.port means default or unknown.

And we expect server.port to be available to all HTTP server instrumentation.

Merge requirement checklist

@trask trask force-pushed the make-server-port-required-on-server-side branch from cd7259d to ac3086a Compare October 12, 2023 17:24
@trask trask marked this pull request as ready for review October 12, 2023 17:27
@trask trask requested review from a team October 12, 2023 17:27
model/http-common.yaml Outdated Show resolved Hide resolved
@AlexanderWert AlexanderWert merged commit cee22ec into open-telemetry:main Oct 16, 2023
9 checks passed
@trask trask deleted the make-server-port-required-on-server-side branch October 16, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

8 participants