Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename jvm.classes.current_loaded to jvm.classes.count #60

Merged
merged 14 commits into from
Aug 16, 2023
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -84,3 +84,5 @@ release.
([#55](https://github.com/open-telemetry/semantic-conventions/pull/55))
- Split out sections for proposed stable JVM metrics and experimental JVM metrics.
([#56](https://github.com/open-telemetry/semantic-conventions/pull/56))
- Rename `process.runtime.jvm.classes.current_loaded` to `process.runtime.jvm.classes.count`.
([#60](https://github.com/open-telemetry/semantic-conventions/pull/60))
3 changes: 3 additions & 0 deletions schemas/1.21.0
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,9 @@ versions:
# https://github.com/open-telemetry/semantic-conventions/pull/53
- rename_metrics:
process.runtime.jvm.cpu.utilization: process.runtime.jvm.cpu.recent_utilization
# https://github.com/open-telemetry/semantic-conventions/pull/60
- rename_metrics:
process.runtime.jvm.classes.current_loaded: process.runtime.jvm.classes.count
1.20.0:
spans:
changes:
Expand Down
14 changes: 7 additions & 7 deletions semantic_conventions/metrics/process-runtime-jvm-metrics.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,13 @@ groups:
type: boolean
requirement_level: recommended

- id: metric.process.runtime.jvm.classes.count
type: metric
metric_name: process.runtime.jvm.classes.count
brief: "Number of classes currently loaded."
instrument: updowncounter
unit: "{class}"

trask marked this conversation as resolved.
Show resolved Hide resolved
- id: metric.process.runtime.jvm.classes.loaded
type: metric
metric_name: process.runtime.jvm.classes.loaded
Expand All @@ -107,13 +114,6 @@ groups:
instrument: counter
unit: "{class}"

- id: metric.process.runtime.jvm.classes.current_loaded
type: metric
metric_name: process.runtime.jvm.classes.current_loaded
brief: "Number of classes currently loaded."
instrument: updowncounter
unit: "{class}"

- id: metric.process.runtime.jvm.cpu.time
type: metric
metric_name: process.runtime.jvm.cpu.time
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ semantic conventions when instrumenting runtime environments.
* [Metric: `process.runtime.jvm.threads.count`](#metric-processruntimejvmthreadscount)
* [Metric: `process.runtime.jvm.classes.loaded`](#metric-processruntimejvmclassesloaded)
* [Metric: `process.runtime.jvm.classes.unloaded`](#metric-processruntimejvmclassesunloaded)
* [Metric: `process.runtime.jvm.classes.current_loaded`](#metric-processruntimejvmclassescurrent_loaded)
* [Metric: `process.runtime.jvm.classes.count`](#metric-processruntimejvmclassescount)
* [Metric: `process.runtime.jvm.cpu.time`](#metric-processruntimejvmcputime)
* [Metric: `process.runtime.jvm.cpu.recent_utilization`](#metric-processruntimejvmcpurecent_utilization)
- [JVM Metrics (Experimental)](#jvm-metrics-experimental)
Expand Down Expand Up @@ -259,18 +259,18 @@ This metric is obtained from [`ClassLoadingMXBean#getUnloadedClassCount()`](http
<!-- semconv metric.process.runtime.jvm.classes.unloaded(full) -->
<!-- endsemconv -->

### Metric: `process.runtime.jvm.classes.current_loaded`
### Metric: `process.runtime.jvm.classes.count`

This metric is [recommended][MetricRecommended].
This metric is obtained from [`ClassLoadingMXBean#getLoadedClassCount()`](https://docs.oracle.com/javase/8/docs/api/java/lang/management/ClassLoadingMXBean.html#getLoadedClassCount--).

<!-- semconv metric.process.runtime.jvm.classes.current_loaded(metric_table) -->
<!-- semconv metric.process.runtime.jvm.classes.count(metric_table) -->
| Name | Instrument Type | Unit (UCUM) | Description |
| -------- | --------------- | ----------- | -------------- |
| `process.runtime.jvm.classes.current_loaded` | UpDownCounter | `{class}` | Number of classes currently loaded. |
| `process.runtime.jvm.classes.count` | UpDownCounter | `{class}` | Number of classes currently loaded. |
<!-- endsemconv -->

<!-- semconv metric.process.runtime.jvm.classes.current_loaded(full) -->
<!-- semconv metric.process.runtime.jvm.classes.count(full) -->
<!-- endsemconv -->

### Metric: `process.runtime.jvm.cpu.time`
Expand Down