-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix problem in xray-lambda
propagator definition
#778
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the problem comes from this "late" addition: > To avoid potential issues when extracting with an active span context, the xray-lambda propagator SHOULD check if the provided context already has an active span context. If found, the propagator SHOULD return the provided context unmodified. This is a problem because `xray-lambda` can't check the original context, only the context that is provided to it, which is modified by prior propagators in the chain. This means if the original carrier has an x-ray context and an x-ray environment variable set, and if the xray propagator is configured as we expect it to be, then the xray-lambda will be either overwritten (if configured first), or will no-op because it detects an existing span context. Proposed solution: change `xray-lambda` to replace `xray` in the configured list instead of work together with. This way, it is able to check the context before `xray` modifies it.
joaopgrassi
reviewed
Feb 28, 2024
jsuereth
approved these changes
Feb 28, 2024
trask
approved these changes
Feb 28, 2024
rapphil
reviewed
Feb 28, 2024
rapphil
reviewed
Feb 28, 2024
Co-authored-by: Raphael Philipe Mendes da Silva <rapphil@gmail.com> Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
rapphil
approved these changes
Feb 28, 2024
lmolkova
reviewed
Feb 28, 2024
lmolkova
approved these changes
Feb 28, 2024
joaopgrassi
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the problem comes from this "late" addition:
This is a problem because
xray-lambda
can't check the original context, only the context that is provided to it, which is modified by prior propagators in the chain.This means if the original carrier has an x-ray context and an x-ray environment variable set, and if the xray propagator is configured as we expect it to be, then the xray-lambda will be either overwritten (if configured first), or will no-op because it detects an existing span context.
Proposed solution: change
xray-lambda
to replacexray
in the configured list instead of work together with. This way, it is able to check the context beforexray
modifies it.Merge requirement checklist
[chore]