-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] Mark attributes and metrics as experimental explicitly #781
[chore] Mark attributes and metrics as experimental explicitly #781
Conversation
Thanks @joaopgrassi for the thorough review! I took away .NET semconv from this PR - they are marked as stable, but refer to experimental attributes. I also got into some weird issues with current version of build-tools. I'll follow up on .NET separately. So this PR should not have any controversial changes now and is ready for review again. |
e04f4c7
to
1e98ade
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did my best to look at each individual file attribute, but once the tooling changes are available and we add the check, we may find out others we may have missed, so not worried about it.
Some conflicts need to be resolved. @lmolkova please take care of those before merging. |
I'm not opposed to making it explicit, but why not set the default stability level as |
see open-telemetry/build-tools#267 (comment)
|
0de1c32
to
e5d0d48
Compare
Changes
In preparation for build-tools update (open-telemetry/build-tools#272) we want to set stability explicitly on all implicit experimental attributes and metrics.
Merge requirement checklist
[chore]
schema-next.yaml updated with changes to existing conventions.