Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Mark attributes and metrics as experimental explicitly #781

Merged

Conversation

lmolkova
Copy link
Contributor

Changes

In preparation for build-tools update (open-telemetry/build-tools#272) we want to set stability explicitly on all implicit experimental attributes and metrics.

Merge requirement checklist

@lmolkova lmolkova requested review from a team February 28, 2024 07:34
@lmolkova lmolkova requested a review from a team February 28, 2024 07:34
model/metrics/dotnet/dotnet-aspnetcore.yaml Outdated Show resolved Hide resolved
model/metrics/dotnet/dotnet-kestrel.yaml Outdated Show resolved Hide resolved
model/metrics/dotnet/dotnet-http.yaml Outdated Show resolved Hide resolved
model/metrics/dotnet/dotnet-signalr.yaml Outdated Show resolved Hide resolved
model/scope/exporter/exporter.yaml Outdated Show resolved Hide resolved
@lmolkova lmolkova marked this pull request as draft February 28, 2024 17:06
@lmolkova
Copy link
Contributor Author

Thanks @joaopgrassi for the thorough review!

I took away .NET semconv from this PR - they are marked as stable, but refer to experimental attributes. I also got into some weird issues with current version of build-tools. I'll follow up on .NET separately.

So this PR should not have any controversial changes now and is ready for review again.

@lmolkova lmolkova marked this pull request as ready for review February 29, 2024 05:34
@lmolkova lmolkova force-pushed the explicit-experimental-stability branch from e04f4c7 to 1e98ade Compare February 29, 2024 05:34
Copy link
Member

@joaopgrassi joaopgrassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did my best to look at each individual file attribute, but once the tooling changes are available and we add the check, we may find out others we may have missed, so not worried about it.

@ChrsMark
Copy link
Member

ChrsMark commented Mar 5, 2024

Some conflicts need to be resolved. @lmolkova please take care of those before merging.

@trisch-me
Copy link
Contributor

I'm not opposed to making it explicit, but why not set the default stability level as experimental?

@trask
Copy link
Member

trask commented Mar 5, 2024

see open-telemetry/build-tools#267 (comment)

Given the problems we've had with experimental things being treated as "defacto stable", I think I'd support requiring stability attribute on everything

@lmolkova lmolkova force-pushed the explicit-experimental-stability branch from 0de1c32 to e5d0d48 Compare March 6, 2024 01:07
@lmolkova lmolkova merged commit 0d963c4 into open-telemetry:main Mar 6, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

8 participants