Generate database metrics semconv from YAML #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszrzeszutek
approved these changes
Jun 7, 2023
|
Thanks @joaopgrassi ! |
jsuereth
approved these changes
Jun 26, 2023
joaopgrassi
force-pushed
the
feat/database-metrics-yaml
branch
2 times, most recently
from
787cd88 to
7803036
Compare
|
Rebased and fixed the issues after the re-structure. This is good to go! Note: I didn't address the attribute namespace topic in this PR. The goal is to simply replicate the status quo for now. |
jsuereth
approved these changes
Jul 6, 2023
joaopgrassi
force-pushed
the
feat/database-metrics-yaml
branch
from
10cb63f to
a6d78f8
Compare
joaopgrassi
force-pushed
the
feat/database-metrics-yaml
branch
from
a6d78f8 to
0d4377c
Compare
|
@joaopgrassi would you mind rebasing this on latest? I'd love to merge it now. |
|
@jsuereth done! I checked everything against the current version one more time, all is the same. |
reyang
approved these changes
Aug 1, 2023
bryce-b
pushed a commit
to bryce-b/semantic-conventions
that referenced
this pull request
Aug 8, 2023
rapphil
pushed a commit
to rapphil/semantic-conventions
that referenced
this pull request
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #79
CC @mateuszrzeszutek @haddasbronfman as previous authors