Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stable_only flag to semconv JQ helpers #588

Merged
merged 8 commits into from
Feb 7, 2025

Conversation

lmolkova
Copy link
Contributor

@lmolkova lmolkova commented Feb 5, 2025

Fixes #569

@lmolkova lmolkova requested a review from a team as a code owner February 5, 2025 21:06
@lmolkova lmolkova requested a review from Copilot February 5, 2025 21:07

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • defaults/jq/semconv.jq: Language not supported
Comments suppressed due to low confidence (1)

CHANGELOG.md:189

  • [nitpick] The term 'stability levels' is inconsistent with the rest of the documentation. It should be 'stability statuses' to match the terminology used elsewhere.
* exclude_stability: a list of stability levels to exclude.
CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Jeremy Blythe <jeremyblythe@gmail.com>
Copy link
Contributor

@lquerel lquerel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lquerel lquerel merged commit d251f30 into open-telemetry:main Feb 7, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add include_stability config into semconv_grouped_attributes
4 participants