Skip to content

Commit

Permalink
feat!: require node >= 14
Browse files Browse the repository at this point in the history
this allows us to use the analyzer without a build
  • Loading branch information
bennypowers committed Aug 18, 2021
1 parent 010bada commit 24ca118
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 29 deletions.
15 changes: 2 additions & 13 deletions .github/workflows/verify-node.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,26 +12,15 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [12.x, 14.x]
node-version: [14.x, 16.x]
steps:
- uses: actions/checkout@v2

- name: Setup Node ${{ matrix.node-version }}
uses: actions/setup-node@v2
with:
node-version: ${{ matrix.node-version }}

- name: Get yarn cache directory path
id: yarn-cache-dir-path
run: echo "::set-output name=dir::$(yarn cache dir)"

- uses: actions/cache@v2
id: yarn-cache # use this to check for `cache-hit` (`steps.yarn-cache.outputs.cache-hit != 'true'`)
with:
path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }}
restore-keys: |
${{ runner.os }}-yarn-
cache: 'yarn'

- name: Install dependencies
run: yarn --frozen-lockfile
Expand Down
17 changes: 3 additions & 14 deletions .github/workflows/verify-windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,22 +18,11 @@ jobs:
- uses: actions/checkout@v2

- name: Setup Node 12.x
- name: Setup Node 14.x
uses: actions/setup-node@v2
with:
node-version: 12.x

- name: Get yarn cache directory path
id: yarn-cache-dir-path
run: echo "::set-output name=dir::$(yarn cache dir)"

- uses: actions/cache@v2
id: yarn-cache # use this to check for `cache-hit` (`steps.yarn-cache.outputs.cache-hit != 'true'`)
with:
path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }}
restore-keys: |
${{ runner.os }}-yarn-
node-version: 14.x
cache: 'yarn'

- name: Install dependencies
run: yarn --frozen-lockfile
Expand Down
4 changes: 2 additions & 2 deletions src/create.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ import { AppMixin } from './generators/app/index.js';

(async () => {
try {
if (semver.lte(process.version, '10.12.0')) {
console.log(chalk.bgRed('\nUh oh! Looks like you dont have Node v10.12.0 installed!\n'));
if (!semver.gte(process.version, '14.0.0')) {
console.log(chalk.bgRed('\nUh oh! Looks like you dont have Node v14 installed!\n'));
console.log(`You can do this by going to ${chalk.underline.blue(`https://nodejs.org/`)}
Or if you use nvm:
Expand Down

0 comments on commit 24ca118

Please sign in to comment.