-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat]: add custom-elements-manifest analyzer #48
Comments
Some things to think about are:
I know some people have strong opinions on code reviews/making sure that the CEM has updated correctly, I also know people wont like seeing CEM changes in their PRs necessarily, so we'd have to make some kind of decision there.
Clever cloud starts the analyzer in watch mode kind of as a side effect of the web dev server config, so the analyzer will always run when the server runs. We could also consider creating a separate dev-server plugin to run the analyzer, maybe thats a bit 'cleaner'. It would be nice to have the analyzer run in watch mode especially when the new version of storybook releases and makes its way into storybook-prebuilt, because then users will have up-to-date knobs/controls as they write code. |
i think we shouldn't check the manifest in. imo it's a build artifact should that plugin live in cem repo or dev server repo cc @LarsDenBakker |
I agree. Maybe we go with that for now, we can always change it
I think its fine to add it to the cem repo |
ok i'll start here then swing back to the build plugin if i have time |
Steps:
@custom-elements-manifest/analyzer
as devdep to all templatesanalyze
script to all templatescc @thepassle
The text was updated successfully, but these errors were encountered: