fix(demoing-storybook): use " for stories glob to support windows

open-wc · Dec 12, 2019 · 20d9db0 · 20d9db0
1 parent dc2eef7
commit 20d9db0
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 9 deletions.
diff --git a/packages/create/src/generators/app-lit-element/templates/_package.json b/packages/create/src/generators/app-lit-element/templates/_package.json
@@ -3,8 +3,8 @@
   "license": "MIT",
   "scripts": {
     "start": "es-dev-server --app-index index.html --node-resolve --open --watch",
-    "storybook": "start-storybook --stories 'components/*/stories/*.stories.{js,mdx}' --node-resolve --watch --open",
-    "storybook:build": "build-storybook --stories 'components/*/stories/*.stories.{js,mdx}'"
+    "storybook": "start-storybook --stories \"components/*/stories/*.stories.{js,mdx}\" --node-resolve --watch --open",
+    "storybook:build": "build-storybook --stories \"components/*/stories/*.stories.{js,mdx}\""
   },
   "dependencies": {
     "lit-html": "^1.0.0",

diff --git a/packages/demoing-storybook/MIGRATION.md b/packages/demoing-storybook/MIGRATION.md
@@ -6,8 +6,8 @@
   - [From version 0.3.x to 0.4.0](#from-version-03x-to-040)
     - [Storybook Upgrade from 5.1.x to 5.3.x](#storybook-upgrade-from-51x-to-53x)
     - [Dependency changes](#dependency-changes)
-    - [Removed `default-storybook-webpack-config.js`](#removed-default-storybook-webpack-configjs)
-    - [Replaced `withClassPropertiesKnobs` with a decorator `withWebComponentsKnobs`](#replaced-withclasspropertiesknobs-with-a-decorator-withwebcomponentsknobs)
+    - [Removed default-storybook-webpack-config.js](#removed-default-storybook-webpack-configjs)
+    - [Replaced withClassPropertiesKnobs with a decorator withWebComponentsKnobs](#replaced-withclasspropertiesknobs-with-a-decorator-withwebcomponentsknobs)
 
 If you did not modify your configurations then you can upgrade to the latest version by rerunning the generator.
 
@@ -79,8 +79,8 @@ If you had a custom `require.context` which is different to the default `./stori
 
 ```json
 "scripts": {
-  "storybook": "start-storybook --stories 'some/path/to/stories/*.stories.{js,mdx}' --node-resolve --watch --open",
-  "storybook:build": "build-storybook --stories 'some/path/to/stories/*.stories.{js,mdx}'"
+  "storybook": "start-storybook --stories \"some/path/to/stories/*.stories.{js,mdx}\" --node-resolve --watch --open",
+  "storybook:build": "build-storybook --stories \"some/path/to/stories/*.stories.{js,mdx}\""
 },
 ```
 

diff --git a/packages/demoing-storybook/package.json b/packages/demoing-storybook/package.json
@@ -21,9 +21,9 @@
   "scripts": {
     "build:start": "es-dev-server --root-dir static-storybook --app-index index.html --open",
     "prepublishOnly": "../../scripts/insert-header.js",
-    "site:build": "node src/build/cli.js --stories 'demo/stories/*.stories.{js,mdx}' --config-dir demo/.storybook -o ../../_site/demoing-storybook",
-    "storybook": "node src/start/cli.js --stories 'packages/demoing-storybook/demo/stories/*.stories.{js,mdx}' --config-dir packages/demoing-storybook/demo/.storybook --root-dir ../../ --node-resolve --watch --open",
-    "storybook:build": "node src/build/cli.js --stories 'demo/stories/*.stories.{js,mdx}' --config-dir demo/.storybook"
+    "site:build": "node src/build/cli.js --stories \"demo/stories/*.stories.{js,mdx}\" --config-dir demo/.storybook -o ../../_site/demoing-storybook",
+    "storybook": "node src/start/cli.js --stories \"packages/demoing-storybook/demo/stories/*.stories.{js,mdx}\" --config-dir packages/demoing-storybook/demo/.storybook --root-dir ../../ --node-resolve --watch --open",
+    "storybook:build": "node src/build/cli.js --stories \"demo/stories/*.stories.{js,mdx}\" --config-dir demo/.storybook"
   },
   "files": [
     "*.js",