Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use schedule traits v3 instead of v1 #1001

Merged
merged 1 commit into from
May 14, 2024
Merged

Conversation

zjb0807
Copy link
Contributor

@zjb0807 zjb0807 commented May 13, 2024

closes: #995

@zjb0807 zjb0807 requested a review from xlc May 13, 2024 10:34
Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.93%. Comparing base (288218c) to head (4c7dae0).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1001      +/-   ##
==========================================
+ Coverage   85.90%   85.93%   +0.02%     
==========================================
  Files          92       92              
  Lines       11132    11124       -8     
==========================================
- Hits         9563     9559       -4     
+ Misses       1569     1565       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zjb0807 zjb0807 merged commit f2fc5ee into master May 14, 2024
5 checks passed
@zjb0807 zjb0807 deleted the upgrade-schedule-traits-v3 branch May 14, 2024 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

move from deprecated v1::Name to v3::Name trait
2 participants