Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

polkadot v1.12.0 #1003

Merged
merged 8 commits into from
Jun 3, 2024
Merged

polkadot v1.12.0 #1003

merged 8 commits into from
Jun 3, 2024

Conversation

clangenb
Copy link
Contributor

@clangenb clangenb commented May 30, 2024 •
edited
Loading

Noteworthy changes

I would be very happy if this is released soon on crates.io ;)

@clangenb clangenb mentioned this pull request May 30, 2024
Open
@zjb0807
Copy link
Contributor

zjb0807 commented May 30, 2024

Please update https://github.com/open-web3-stack/open-runtime-module-library/blob/master/Cargo.dev.toml to use polkadot-sdk v1.12.0

@clangenb
Copy link
Contributor Author

clangenb commented May 31, 2024 •
edited
Loading

Ah damn, forgot to commit this because it was in the Cargo.toml only. Fixed it now.

I could have noticed this earlier if the CI ran. I am wondering: as this isn't my first contribution, and neither my last. Is it possible to make the CI run with my PRs automatically?

@clangenb
Copy link
Contributor Author

I see that the coverage workflow failed due to the rate limit. Can we merge it like this?

zjb0807
zjb0807 approved these changes May 31, 2024
View reviewed changes
Copy link
Contributor

@zjb0807 zjb0807 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zjb0807
Copy link
Contributor

zjb0807 commented May 31, 2024

I could have noticed this earlier if the CI ran. I am wondering: as this isn't my first contribution, and neither my last. Is it possible to make the CI run with my PRs automatically?

This should be a GitHub setting. But it seems to run automatically.

I see that the coverage workflow failed due to the rate limit. Can we merge it like this?

The coverage is not required. It's fine.

@clangenb
Copy link
Contributor Author

Alright I see. I thought that I read that it needs a maintainer to run the action.

Cool, thanks a lot!

@xlc xlc merged commit 1846675 into open-web3-stack:master Jun 3, 2024
2 of 3 checks passed
ipapandinas pushed a commit to AstarNetwork/open-runtime-module-library that referenced this pull request Sep 4, 2024
@clangenb @ipapandinas
polkadot v1.12.0 (open-web3-stack#1003)
61fb12e 
* [tokens] update fungible implementation

* [benchmarking] update benchmarks

* [asset-registry] add `XcmRecorder` associated type to mocks

* [tokens] add preservation arg to tests

* [xtokens] add `XcmRecorder` associated type to mocks

* fmt

* [benchmarking] fix tests

* add updated Cargo.dev.toml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xlc xlc xlc approved these changes

@zjb0807 zjb0807 zjb0807 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@clangenb @zjb0807 @xlc