Extend end-to-end tests in people chains #63

rockbmb · 2024-10-17T01:07:18Z

No description provided.

This mistakenly caused identities to remain provisional even after judgement had been passed, due to using the wrong address as the registrar when setting up the chain - Bob instead of Alice.

1. Create an identity 2. Request a judgement on it 3. Have it provided by the test-only Alice registrar This basic test is already quite useful, and can now be extended into other more complex scenarios.

This is required to test pallet extrinsics that require certain origins to be executed e.g. the identity pallet's `addRegistrar` function. The original source for the idea can be found in https://hackmd.io/@xlc/H11BX5BLa#Dispatch-Call

Also refactor tests, add some comments and documentation.

xlc · 2024-10-21T21:19:46Z

can you push the yarn.lock file change

rockbmb · 2024-10-22T01:54:25Z

@xlc Hello!

It's already in the tree, and mine hasn't changed compared to master. Did you detect any issues?

(As an experiment) can I ask that you

modify this line in the subidentity test from await peopleClient.api.rpc('dev_newBlock', { count: 2 }) to await peopleClient.api.rpc('dev_newBlock', { count: 1 })
try running yarn test people.e2e.test -t "setting on-chain identity, adding sub-identities"
from the latest commit?

Subidentity extrinsics fail to be applied immediately after 1 block, but if you try the same thing in a local polkadot.js fork, it will work correctly - odd.

xlc · 2024-10-22T04:34:44Z

The CI is failing and you have modified package.json without modify yarn.lock.

xlc · 2024-10-22T04:37:55Z

also I don't really want any code in the root package. please have the polkadot tests in the polkadot packages under ./packages/polkadot/src, and shared helper in ./packages/shared/src

this means you should add the deps to the shared package, not the root one

xlc · 2024-10-22T04:49:15Z

Few more points:

you should use .dev instead of dev rpc. e.g. await peopleClient.dev.newBlock({ count: 2 })
I highly recommend use snapshots over manually writing assertions. You will see the value (and asserting it remains the same). So you don't need for example print the value and delete the print statement later.
If you are unsure why something isn't going as expected, increase the test timeout in vitest.config.mts file and add peopleClient.pause() to pause the test. Check the logs, it will show the ports of the chopsticks instance and you can use pjs apps to connect to it and inspect the events / send tx etc.

rockbmb · 2024-10-22T12:30:40Z

@xlc thank you for the review!

I will address your comments in coming commits.

Specifically, in People chains' E2E tests.

rockbmb · 2024-10-26T01:25:57Z

@xlc I've addressed your review - could you take another look?

xlc · 2024-10-26T07:02:10Z

CI is still failing due to yarn.lock file, otherwise looks fine

rockbmb · 2024-10-26T13:00:38Z

@xlc true (again) - apologies for the oversight. I'll push a fix.

xlc · 2024-10-26T23:15:23Z

the lint error indicates multiple versions of chopsticks are included, which is not good. you can confirm it by looking the yarn.lock file
do a yarn update chopsticks should resolve the error. make sure you do yarn lint locally to confirm. otherwise delete yarn.lock file and regenerate it could also work. but that will update other packages as well, which isn't bad, but just may have unexpected side effects

rockbmb · 2024-10-27T16:51:31Z

yarn lint does confirm the issue.

In the end, I simply rebuilt yarn.lock. I inspected it, and there is now only one version of @acala-network/chopsticks being used.

rockbmb · 2024-10-27T23:44:28Z

I've found the issue with the latest CI failures. Pushing a fix.

This is because people E2E tests require Bob's address to be loaded with funds, which interferes with the people chain XCM tests' snapshots.

# Description E2E tests to Polkadot/Kusama's people chains (in open-web3-stack/polkadot-ecosystem-tests#63) revealed that 2 of the identity pallet's extrinsics did not emit events in case of success: * `pallet_identity::rename_sub`, and * `pallet_identity::set_subs` This PR fixes that. ## Integration Other than 2 extrinsics emiting an event when previously they did not, no other behavior in pallets/extrinsics was modified, so no integration is needed. ## Review Notes N/A

rockbmb added 10 commits October 17, 2024 01:39

Add Alice as registrar to People chains for E2E tests

f12c2bd

Add basic E2E test to identity registration on Polkadot

26c17c3

Create MRE test for identity + Riot/Matrix issue

fe268ad

Fix issue with wrong registrar address being used

c8c32c0

This mistakenly caused identities to remain provisional even after judgement had been passed, due to using the wrong address as the registrar when setting up the chain - Bob instead of Alice.

Extend test on starter identity flow

25b6d82

1. Create an identity 2. Request a judgement on it 3. Have it provided by the test-only Alice registrar This basic test is already quite useful, and can now be extended into other more complex scenarios.

Create basic test for identity pallet features

5d54efc

Rely on chopsticks API for new block (over manual RPC)

a72d9e6

Add method to (sudo) execute calls in parachain

9e03133

This is required to test pallet extrinsics that require certain origins to be executed e.g. the identity pallet's `addRegistrar` function. The original source for the idea can be found in https://hackmd.io/@xlc/H11BX5BLa#Dispatch-Call

Add assertions to registrar addition test

8aae476

Add registrar addition test to Polkadot/Kusama

8b5323a

rockbmb changed the title ~~People chain e2e tests~~ Extend end-to-end tests in people chains Oct 17, 2024

Add e2e test to identity cancellation/clearing

79a0feb

rockbmb force-pushed the people-chain-e2e-tests branch 2 times, most recently from 989753a to 374fd91 Compare October 18, 2024 19:14

Add e2e test to subidentity extrinsics

52f6914

rockbmb force-pushed the people-chain-e2e-tests branch from 374fd91 to 52f6914 Compare October 18, 2024 19:36

Create test to identity set -> reset

0b64c78

Also refactor tests, add some comments and documentation.

rockbmb force-pushed the people-chain-e2e-tests branch from 1034398 to 0b64c78 Compare October 21, 2024 17:25

rockbmb marked this pull request as ready for review October 21, 2024 17:27

Refactor Kusama/Polkadot people e2e tests to same module

e267d55

rockbmb added 4 commits October 23, 2024 16:41

Refactor test structure per PR review

38ae025

Rely on .dev instead of .rpc where possible

b20bb78

Use vitest snapshots over assertions in E2E tests

b2d2062

Specifically, in People chains' E2E tests.

Use snapshots in identity setting/resetting E2E test

99b15f2

rockbmb added 5 commits October 25, 2024 01:19

Use snapshots in judgement cancellation E2E test

090cafb

Use snapshots in subidentity E2E test

89ad114

Use snapshots in registrar addition E2E test

8d90365

Guard against wrong origin in add registrar test

ed9b177

Add Kusama people chain E2E snapshots

99e863b

rockbmb added 2 commits October 26, 2024 18:57

Bump yarn.lock

63c6a9f

Merge branch 'master' into people-chain-e2e-tests

f2b5d22

Rebuild yarn.lock to fix chopsticks' version

819cfb6

rockbmb added 2 commits October 28, 2024 00:46

Remove unnecessary reexport from people chain mod

072a987

Use different "to" address in people XCM tests

3e5730a

This is because people E2E tests require Bob's address to be loaded with funds, which interferes with the people chain XCM tests' snapshots.

xlc approved these changes Oct 28, 2024

View reviewed changes

xlc merged commit 5f93dcf into open-web3-stack:master Oct 28, 2024
17 checks passed

rockbmb deleted the people-chain-e2e-tests branch October 28, 2024 12:21

rockbmb mentioned this pull request Oct 28, 2024

Add missing events to identity pallet paritytech/polkadot-sdk#6261

Merged

rockbmb mentioned this pull request Nov 4, 2024

Add more integrations tests to People chains polkadot-fellows/runtimes#499

Open

1 task

rockbmb mentioned this pull request Nov 22, 2024

Add governance e2e tests #115

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Extend end-to-end tests in people chains #63

Extend end-to-end tests in people chains #63

rockbmb commented Oct 17, 2024

xlc commented Oct 21, 2024

rockbmb commented Oct 22, 2024 •

edited

Loading

xlc commented Oct 22, 2024

xlc commented Oct 22, 2024 •

edited

Loading

xlc commented Oct 22, 2024

rockbmb commented Oct 22, 2024

rockbmb commented Oct 26, 2024

xlc commented Oct 26, 2024 •

edited

Loading

rockbmb commented Oct 26, 2024 •

edited

Loading

xlc commented Oct 26, 2024

rockbmb commented Oct 27, 2024

rockbmb commented Oct 27, 2024

Extend end-to-end tests in people chains #63

Extend end-to-end tests in people chains #63

Conversation

rockbmb commented Oct 17, 2024

xlc commented Oct 21, 2024

rockbmb commented Oct 22, 2024 • edited Loading

xlc commented Oct 22, 2024

xlc commented Oct 22, 2024 • edited Loading

xlc commented Oct 22, 2024

rockbmb commented Oct 22, 2024

rockbmb commented Oct 26, 2024

xlc commented Oct 26, 2024 • edited Loading

rockbmb commented Oct 26, 2024 • edited Loading

xlc commented Oct 26, 2024

rockbmb commented Oct 27, 2024

rockbmb commented Oct 27, 2024

rockbmb commented Oct 22, 2024 •

edited

Loading

xlc commented Oct 22, 2024 •

edited

Loading

xlc commented Oct 26, 2024 •

edited

Loading

rockbmb commented Oct 26, 2024 •

edited

Loading