You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
So, it is a matter of finding an alternative way to parse the lines containing build directives in the tests. Until then, we will maintain the old directive format in the tests.
The text was updated successfully, but these errors were encountered:
This commit removes the line syntax:
// +build
by using just the syntax:
//go:build
which is supported starting from Go 1.17 and has been considered
deprecated starting from Go 1.18.
Note that, in tests, the old syntax is kept. See #956.
PR #955 removed the use of the
// +build
syntax, which has been deprecated since Go version 1.18.However, the tests in the
test/compare
directory have been maintained as they are because the parsing of test directives, which occurs here:scriggo/test/compare/run.go
Lines 160 to 168 in 527b6c2
uses the package:
https://pkg.go.dev/github.com/rogpeppe/go-internal@v1.13.1/imports
whose function
ShouldBuild
still only supports the old format of build tags:https://pkg.go.dev/github.com/rogpeppe/go-internal@v1.13.1/imports#ShouldBuild
So, it is a matter of finding an alternative way to parse the lines containing build directives in the tests. Until then, we will maintain the old directive format in the tests.
The text was updated successfully, but these errors were encountered: