-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix v2 key naming for conflicts across publishers / rulesets #402
Comments
I think they could be separated into a generic id the API could then pick items based on ruleset: and wotc and dnd5e should proabably be the default if you don't supply anything, since these are usually seen as the baseline. |
I think the relatively final naming convention on this will be: {slugified name}-{document-shortname}. magic-missile-srd There are a few document shortnames that needs to be adjusted. "warlock" for example is pretty misleading. I will take a crack at this fairly soon. |
This would be resolved with #462 |
This has been resolved. |
Acolyte is a good example. There's one in wotc and one in a5e.
Prepending the publisher name is good, but in what hierarchy? Which publisher is best?
Prepending the ruleset might work, but could there be two "Obsidian Greatsword" items both in 5e?
I suppose I'd tend towards publisher if I had to choose. Maybe we could add a publisher shortname?
Any thoughts?
Originally posted by @augustjohnson in #394 (comment)
The text was updated successfully, but these errors were encountered: