423 consider refactoring v2 classnames with parent in the name #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he-name' of github.com:open5e/open5e-api into 423-consider-refactoring-v2-classnames-with-parent-in-the-name
…-the-name' and '423-consider-refactoring-v2-classnames-with-parent-in-the-name' of github.com:open5e/open5e-api into 423-consider-refactoring-v2-classnames-with-parent-in-the-name
…-the-name' and '423-consider-refactoring-v2-classnames-with-parent-in-the-name' of github.com:open5e/open5e-api into 423-consider-refactoring-v2-classnames-with-parent-in-the-name
…he-name' of github.com:open5e/open5e-api into 423-consider-refactoring-v2-classnames-with-parent-in-the-name
|
Merging in because nobody wants to test this crap :/ |
augustjohnson
deleted the
423-consider-refactoring-v2-classnames-with-parent-in-the-name
branch
|
Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored class names for all v2 objects to show inheritance.
Standardized on "parent" to be the upwards field for all objects.
Refactored set keys to be universally unique, and standardized in format.
Tested by running tests, visiting all endpoints, spot checking items, import/export parity, etc.