Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Descriptions to Tome of Beasts Monsters #189

Merged
merged 4 commits into from
Apr 8, 2023

Conversation

Sturlen
Copy link
Contributor

@Sturlen Sturlen commented Mar 29, 2023

Fixes #186
Monsters changed:

  • ToB1: 349
  • ToB2: 378
  • ToB3: 1

Accessible through the desc field for the relevant monster, if it had one. No changes to the model were necessary.

All descriptions are from the Kobold Press FoundryVTT module

Some escaped unicode characters such were unescaped due to how I processed the json files e.g. \u2019 to . Let me know if this is a problem and I'll figure out another workflow.

@Sturlen Sturlen marked this pull request as draft March 30, 2023 12:02
@Sturlen Sturlen marked this pull request as ready for review April 3, 2023 19:18
@Gredelston
Copy link
Collaborator

This looks great! Thanks for the work here, Sturlen.

AFAIK we don't have an official stance on escaped vs. unescaped characters -- or if we do, it's not documented anywhere. LGTM for now, and maybe we'll standardize later.

@Gredelston Gredelston merged commit 5372e33 into open5e:staging Apr 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Monster descriptions to kobold press monsters
2 participants