Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Creature Codex stuff. #21

Merged
merged 8 commits into from
Oct 2, 2019
Merged

Conversation

RealDeuce
Copy link
Contributor

This is likely broken... and I'm just guessing at tables and line breaks.

This is likely broken... and I'm just guessing at tables and line breaks.
@RealDeuce
Copy link
Contributor Author

I suspect how I shoe-horned the OGL into the file is a part of why the check failed... but I can't actually see the details.

@eepMoody
Copy link
Collaborator

@RealDeuce it looks like the only issue was that your actions didn't include an "attack_bonus" except where it actually makes sense. The other files we used always included it, but it was simple enough to make the importer more flexible so we don't have to worry about it!

Assuming this passes, I think this PR is good to go.

@RealDeuce
Copy link
Contributor Author

Did the table in the Elophar "Possessed by Ancestors" ability work?

@eepMoody
Copy link
Collaborator

eepMoody commented Oct 2, 2019

@RealDeuce Took me a bit to find the right way to test this, but yeah the tables look good! Gonna merge this in.

@eepMoody eepMoody merged commit 9451b54 into open5e:master Oct 2, 2019
@RealDeuce RealDeuce deleted the creature-codex branch October 31, 2019 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants